Merge pull request eugenp#29 from rachelshu/master

Eugen · Eugen · commit 706ec1d67dad · 2014-07-21T15:50:19.000+03:00
Changes to reduce fields not necessary.
diff --git a/jackson/src/test/java/org/baeldung/jackson/field/MyDtoGetter.java b/jackson/src/test/java/org/baeldung/jackson/field/MyDtoGetter.java
@@ -3,8 +3,7 @@
 public class MyDtoGetter {
 
     private String stringValue;
-    int intValue;
-    public boolean booleanValue;
+    private int intValue;
 
     public MyDtoGetter() {
         super();
@@ -15,7 +14,6 @@ public MyDtoGetter(final String stringValue, final int intValue, final boolean b
 
         this.stringValue = stringValue;
         this.intValue = intValue;
-        this.booleanValue = booleanValue;
     }
 
     // API
diff --git a/jackson/src/test/java/org/baeldung/jackson/field/MyDtoGetterImplicitDeserialization.java b/jackson/src/test/java/org/baeldung/jackson/field/MyDtoGetterImplicitDeserialization.java
@@ -3,7 +3,6 @@
 public class MyDtoGetterImplicitDeserialization {
 
     private String stringValue;
-    int intValue;
     public boolean booleanValue;
 
     public MyDtoGetterImplicitDeserialization() {
@@ -14,7 +13,6 @@ public MyDtoGetterImplicitDeserialization(final String stringValue, final int in
         super();
 
         this.stringValue = stringValue;
-        this.intValue = intValue;
         this.booleanValue = booleanValue;
     }
 
@@ -24,8 +22,4 @@ public String getStringValue() {
         return stringValue;
     }
 
-    public int getIntValue() {
-        return intValue;
-    }
-
 }
diff --git a/jackson/src/test/java/org/baeldung/jackson/field/MyDtoSetter.java b/jackson/src/test/java/org/baeldung/jackson/field/MyDtoSetter.java
@@ -4,7 +4,6 @@ public class MyDtoSetter {
 
     private String stringValue;
     int intValue;
-    public boolean booleanValue;
 
     public MyDtoSetter() {
         super();
@@ -15,7 +14,6 @@ public MyDtoSetter(final String stringValue, final int intValue, final boolean b
 
         this.stringValue = stringValue;
         this.intValue = intValue;
-        this.booleanValue = booleanValue;
     }
 
     // API
diff --git a/jackson/src/test/java/org/baeldung/jackson/test/JacksonFieldUnitTest.java b/jackson/src/test/java/org/baeldung/jackson/test/JacksonFieldUnitTest.java
@@ -44,34 +44,31 @@ public final void givenDifferentAccessLevels_whenGetterAdded_thenSerializable()
         final String dtoAsString = mapper.writeValueAsString(dtoObject);
         assertThat(dtoAsString, containsString("stringValue"));
         assertThat(dtoAsString, not(containsString("intValue")));
-        assertThat(dtoAsString, containsString("booleanValue"));
         System.out.println(dtoAsString);
     }
 
     @Test
     public final void givenDifferentAccessLevels_whenGetterAdded_thenDeserializable() throws JsonProcessingException, JsonMappingException, IOException {
-        final String jsonAsString = "{\"stringValue\":\"dtoString\",\"intValue\":1,\"booleanValue\":\"true\"}";
+        final String jsonAsString = "{\"stringValue\":\"dtoString\",\"booleanValue\":\"true\"}";
         final ObjectMapper mapper = new ObjectMapper();
 
         final MyDtoGetterImplicitDeserialization dtoObject = mapper.readValue(jsonAsString, MyDtoGetterImplicitDeserialization.class);
 
         assertNotNull(dtoObject);
         assertThat(dtoObject.getStringValue(), equalTo("dtoString"));
-        assertThat(dtoObject.getIntValue(), equalTo(1));
         assertThat(dtoObject.booleanValue, equalTo(true));
     }
 
     @Test
     public final void givenDifferentAccessLevels_whenSetterAdded_thenDeserializable() throws JsonProcessingException, JsonMappingException, IOException {
-        final String jsonAsString = "{\"stringValue\":\"dtoString\",\"intValue\":1,\"booleanValue\":\"true\"}";
+        final String jsonAsString = "{\"stringValue\":\"dtoString\",\"intValue\":1}";
         final ObjectMapper mapper = new ObjectMapper();
 
         final MyDtoSetter dtoObject = mapper.readValue(jsonAsString, MyDtoSetter.class);
 
         assertNotNull(dtoObject);
         assertThat(dtoObject.getStringValue(), equalTo("dtoString"));
         assertThat(dtoObject.anotherGetIntValue(), equalTo(1));
-        assertThat(dtoObject.booleanValue, equalTo(true));
     }
 
     @Test
@@ -83,7 +80,6 @@ public final void givenDifferentAccessLevels_whenSetterAdded_thenStillNotSeriali
         final String dtoAsString = mapper.writeValueAsString(dtoObject);
         assertThat(dtoAsString, containsString("stringValue"));
         assertThat(dtoAsString, not(containsString("intValue")));
-        assertThat(dtoAsString, containsString("booleanValue"));
         System.out.println(dtoAsString);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@`
`3`	`3`	`public class MyDtoGetterImplicitDeserialization {`
`4`	`4`
`5`	`5`	`private String stringValue;`
`6`		`- int intValue;`
`7`	`6`	`public boolean booleanValue;`
`8`	`7`
`9`	`8`	`public MyDtoGetterImplicitDeserialization() {`
`@@ -14,7 +13,6 @@ public MyDtoGetterImplicitDeserialization(final String stringValue, final int in`
`14`	`13`	`super();`
`15`	`14`
`16`	`15`	`this.stringValue = stringValue;`
`17`		`- this.intValue = intValue;`
`18`	`16`	`this.booleanValue = booleanValue;`
`19`	`17`	`}`
`20`	`18`
`@@ -24,8 +22,4 @@ public String getStringValue() {`
`24`	`22`	`return stringValue;`
`25`	`23`	`}`
`26`	`24`
`27`		`- public int getIntValue() {`
`28`		`- return intValue;`
`29`		`- }`
`30`		`-`
`31`	`25`	`}`