Removed all for...of instances

wffranco · wffranco · commit a4b25f2e7e57 · 2016-11-11T06:52:35.000-04:00
- removed from components and docs
diff --git a/docs/affixSidebar.vue b/docs/affixSidebar.vue
@@ -37,13 +37,13 @@ export default {
   methods: {
     scrollSpy () {
       const scrollPosition = document.documentElement.scrollTop || document.body.scrollTop
-      for (let s of this.sections) {
+      this.sections.forEach(s => {
         // 420 = firstSection.getBoundingClientRect().top (when body.scrollTop = 0)
         // = nav.height + header.height + firstSection.margin-top - 6 (for offset)
         if (s.el.offsetTop + 420 <= scrollPosition) {
           this.active = s.id
         }
-      }
+      })
     }
   }
 }
diff --git a/src/Affix.vue b/src/Affix.vue
@@ -38,7 +38,7 @@ export default {
       let element = {}
       const rect = this.$el.getBoundingClientRect()
       const body = document.body
-      for(let type of ['Top','Left']) {
+      ['Top','Left'].forEach(type => {
         let t = type.toLowerCase()
         let ret = window['page' + (type==='Top' ? 'Y' : 'X') + 'Offset']
         const method = 'scroll' + type
@@ -52,7 +52,7 @@ export default {
         }
         scroll[t] = ret
         element[t] = scroll[t] + rect[t] - (this.$el['client'+type] || body['client'+type] || 0)
-      }
+      })
       let fix = scroll.top > element.top - this.offset
       if (this.affixed !== fix) { this.affixed = fix }
     }
diff --git a/src/Select.vue b/src/Select.vue
@@ -142,7 +142,7 @@ export default {
     selected () {
       if (this.options.length === 0) { return '' }
       let foundItems = []
-      for (var item of this.values) {
+      this.values.forEach(item => {
         if (~['number', 'string'].indexOf(typeof item)) {
           let option = null
           if (this.options.some(o => {
@@ -152,7 +152,7 @@ export default {
             }
           })) { foundItems.push(option[this.optionsLabel] || option) }
         }
-      }
+      })
       return foundItems.join(', ')
     },
     classes () {
@@ -275,9 +275,9 @@ export default {
       this.loading = true
       getJSON(this.url).then(data => {
         let options = []
-        for (let opc of data) {
+        data.forEach(opc => {
           if (opc[this.optionsValue] !== undefined && opc[this.optionsLabel] !== undefined) options.push(opc)
-        }
+        })
         this.options = options
         if (!options.length) { this.value = this.value instanceof Array ? [] : null }
       }).always(() => {
diff --git a/src/utils/NodeList.js b/src/utils/NodeList.js
@@ -96,8 +96,6 @@ class NodeList {
     return this
   }
   delete () {
-    let list = NodeListJS([], this.owner)
-    let splice = index => ArrayProto.splice.apply()
     for (let i = this.length - 1, el = this[i]; i; el = this[--i]) {
       if (el.remove) {
         el.remove()
@@ -107,6 +105,7 @@ class NodeList {
         this.splice(i, 1)
       }
     }
+    if (this.length) console.warn('NodeList: Some nodes could not be deleted.')
     return this
   }
   shift (amount) {

Original file line number	Diff line number	Diff line change
`@@ -37,13 +37,13 @@ export default {`
`37`	`37`	`methods: {`
`38`	`38`	`scrollSpy () {`
`39`	`39`	`const scrollPosition = document.documentElement.scrollTop \|\| document.body.scrollTop`
`40`		`- for (let s of this.sections) {`
	`40`	`+ this.sections.forEach(s => {`
`41`	`41`	`// 420 = firstSection.getBoundingClientRect().top (when body.scrollTop = 0)`
`42`	`42`	`// = nav.height + header.height + firstSection.margin-top - 6 (for offset)`
`43`	`43`	`if (s.el.offsetTop + 420 <= scrollPosition) {`
`44`	`44`	`this.active = s.id`
`45`	`45`	`}`
`46`		`- }`
	`46`	`+ })`
`47`	`47`	`}`
`48`	`48`	`}`
`49`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -96,8 +96,6 @@ class NodeList {`
`96`	`96`	`return this`
`97`	`97`	`}`
`98`	`98`	`delete () {`
`99`		`- let list = NodeListJS([], this.owner)`
`100`		`- let splice = index => ArrayProto.splice.apply()`
`101`	`99`	`for (let i = this.length - 1, el = this[i]; i; el = this[--i]) {`
`102`	`100`	`if (el.remove) {`
`103`	`101`	`el.remove()`
`@@ -107,6 +105,7 @@ class NodeList {`
`107`	`105`	`this.splice(i, 1)`
`108`	`106`	`}`
`109`	`107`	`}`
	`108`	`+ if (this.length) console.warn('NodeList: Some nodes could not be deleted.')`
`110`	`109`	`return this`
`111`	`110`	`}`
`112`	`111`	`shift (amount) {`