Skip to content

Commit beb3107

Browse files
committed
Merge pull request mozilla#797 from notmasteryet/tree-41
Warn (not fail) during MD5 verification, new MD5 for intelisa and f1040
2 parents 385b6df + 3965185 commit beb3107

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

test/test.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -323,18 +323,18 @@ def verifyPDFs(manifestList):
323323
if os.access(f, os.R_OK):
324324
fileMd5 = hashlib.md5(open(f, 'rb').read()).hexdigest()
325325
if 'md5' not in item:
326-
print 'ERROR: Missing md5 for file "' + f + '".',
326+
print 'WARNING: Missing md5 for file "' + f + '".',
327327
print 'Hash for current file is "' + fileMd5 + '"'
328328
error = True
329329
continue
330330
md5 = item['md5']
331331
if fileMd5 != md5:
332-
print 'ERROR: MD5 of file "' + f + '" does not match file.',
332+
print 'WARNING: MD5 of file "' + f + '" does not match file.',
333333
print 'Expected "' + md5 + '" computed "' + fileMd5 + '"'
334334
error = True
335335
continue
336336
else:
337-
print 'ERROR: Unable to open file for reading "' + f + '".'
337+
print 'WARNING: Unable to open file for reading "' + f + '".'
338338
error = True
339339
return not error
340340

@@ -365,7 +365,8 @@ def setUp(options):
365365
downloadLinkedPDFs(manifestList)
366366

367367
if not verifyPDFs(manifestList):
368-
raise Exception('ERROR: failed to verify pdfs.')
368+
print 'Unable to verify the checksum for the files that are used for testing.'
369+
print 'Please re-download the files, or adjust the MD5 checksum in the manifest for the files listed above.\n'
369370

370371
for b in testBrowsers:
371372
State.taskResults[b.name] = { }

test/test_manifest.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
},
2020
{ "id": "intelisa-load",
2121
"file": "pdfs/intelisa.pdf",
22-
"md5": "f3ed5487d1afa34d8b77c0c734a95c79",
22+
"md5": "f5712097d29287a97f1278839814f682",
2323
"link": true,
2424
"rounds": 1,
2525
"type": "load"
@@ -194,7 +194,7 @@
194194
},
195195
{ "id": "f1040",
196196
"file": "pdfs/f1040.pdf",
197-
"md5": "7323b50c6d28d959b8b4b92c469b2469",
197+
"md5": "b59272ce19b4a0c5808c8861441b0741",
198198
"link": true,
199199
"rounds": 1,
200200
"type": "load"

0 commit comments

Comments
 (0)