Merge pull request hoisie#201 from hoisie/bad-request

hoisie · web-flow · commit 6f789047ba81 · 2016-08-04T17:58:34.000-07:00
Add a helper method for returning HTTP 400
diff --git a/web.go b/web.go
@@ -55,17 +55,16 @@ func (ctx *Context) Redirect(status int, url_ string) {
 	ctx.ResponseWriter.Write([]byte("Redirecting to: " + url_))
 }
 
+//BadRequest writes a 400 HTTP response
+func (ctx *Context) BadRequest() {
+	ctx.ResponseWriter.WriteHeader(400)
+}
+
 // Notmodified writes a 304 HTTP response
 func (ctx *Context) NotModified() {
 	ctx.ResponseWriter.WriteHeader(304)
 }
 
-// NotFound writes a 404 HTTP response
-func (ctx *Context) NotFound(message string) {
-	ctx.ResponseWriter.WriteHeader(404)
-	ctx.ResponseWriter.Write([]byte(message))
-}
-
 //Unauthorized writes a 401 HTTP response
 func (ctx *Context) Unauthorized() {
 	ctx.ResponseWriter.WriteHeader(401)
@@ -76,6 +75,12 @@ func (ctx *Context) Forbidden() {
 	ctx.ResponseWriter.WriteHeader(403)
 }
 
+// NotFound writes a 404 HTTP response
+func (ctx *Context) NotFound(message string) {
+	ctx.ResponseWriter.WriteHeader(404)
+	ctx.ResponseWriter.Write([]byte(message))
+}
+
 // ContentType sets the Content-Type header for an HTTP response.
 // For example, ctx.ContentType("json") sets the content-type to "application/json"
 // If the supplied value contains a slash (/) it is set as the Content-Type
diff --git a/web_test.go b/web_test.go
@@ -145,6 +145,9 @@ func init() {
 
 	Get("/error/notfound/(.*)", func(ctx *Context, message string) { ctx.NotFound(message) })
 
+	Get("/error/badrequest", func(ctx *Context) { ctx.BadRequest() })
+	Post("/error/badrequest", func(ctx *Context) { ctx.BadRequest() })
+
 	Get("/error/unauthorized", func(ctx *Context) { ctx.Unauthorized() })
 	Post("/error/unauthorized", func(ctx *Context) { ctx.Unauthorized() })
 
@@ -230,6 +233,8 @@ var tests = []Test{
 	//long url
 	{"GET", "/echo/" + strings.Repeat("0123456789", 100), nil, "", 200, strings.Repeat("0123456789", 100)},
 	{"GET", "/writetest", nil, "", 200, "hello"},
+	{"GET", "/error/badrequest", nil, "", 400, ""},
+	{"POST", "/error/badrequest", nil, "", 400, ""},
 	{"GET", "/error/unauthorized", nil, "", 401, ""},
 	{"POST", "/error/unauthorized", nil, "", 401, ""},
 	{"GET", "/error/forbidden", nil, "", 403, ""},
