Skip to content

Commit 8630652

Browse files
committed
Fixes n1k0#18: Node >= 4 compatibility. (n1k0#20)
1 parent ecf4003 commit 8630652

File tree

3 files changed

+23
-8
lines changed

3 files changed

+23
-8
lines changed

.travis.yml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
11
language: node_js
2-
sudo: false
32
node_js:
4-
- '0.10'
3+
- "0.12"
4+
- "4"
5+
- "5"
6+
- "6"
7+
before_install:
8+
- sudo apt-get install python-software-properties
9+
- sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y
10+
- sudo apt-get update
11+
- sudo apt-get install gcc-5 g++-5
12+
- sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-5 80 --slave /usr/bin/g++ g++ /usr/bin/g++-5
13+
- sudo update-alternatives --set gcc /usr/bin/gcc-5

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,6 @@
2929
"chai": "^2.1.*",
3030
"mocha": "^2.1.*",
3131
"sinon": "^1.12.*",
32-
"supertest": "^0.15.*"
32+
"supertest": "^1.2.*"
3333
}
3434
}

server.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,18 @@ app.get("/api/get", function(req, res) {
4242
if (!url) {
4343
return res.status(400).json({error: "Missing url parameter"});
4444
}
45-
scrape(url, {userAgent: userAgent}).then(function(result) {
46-
res.json(sanitize ? sanitizeResult(result) : result);
47-
}).catch(function(err) {
48-
console.log(err);
45+
function handleError(err) {
46+
console.error(err);
4947
res.status(500).json({error: {message: err.message}});
50-
});
48+
}
49+
scrape(url, {userAgent: userAgent})
50+
.then(function(result) {
51+
if (!result) {
52+
throw new Error("No scraped result received.");
53+
}
54+
res.json(sanitize ? sanitizeResult(result) : result);
55+
})
56+
.catch(handleError);
5157
});
5258

5359
exports.serve = function() {

0 commit comments

Comments
 (0)