improve build error handling

ShMcK · ShMcK · commit 60c48ed73937 · 2020-05-31T14:11:59.000-07:00
Signed-off-by: shmck &lt;shawn.j.mckay@gmail.com&gt;
diff --git a/src/build.ts b/src/build.ts
@@ -46,33 +46,72 @@ const parseArgs = (args: string[]): BuildArgs => {
 };
 
 async function build(args: string[]) {
-  const options = parseArgs(args);
+  let options: BuildArgs;
+  try {
+    options = parseArgs(args);
+  } catch (e) {
+    console.error("Error parsing build logs");
+    console.error(e.message);
+    return;
+  }
 
   // path to run build from
   const localPath = path.join(process.cwd(), options.dir);
 
   // load files
-  const [_markdown, _yaml] = await Promise.all([
-    read(path.join(localPath, options.markdown), "utf8"),
-    read(path.join(localPath, options.yaml), "utf8"),
-  ]);
+  let _markdown: string;
+  let _yaml: string;
+  try {
+    [_markdown, _yaml] = await Promise.all([
+      read(path.join(localPath, options.markdown), "utf8"),
+      read(path.join(localPath, options.yaml), "utf8"),
+    ]);
+  } catch (e) {
+    console.error("Error reading file:");
+    console.error(e.message);
+    return;
+  }
 
-  const config = yamlParser.load(_yaml);
+  let config;
+  try {
+    config = yamlParser.load(_yaml);
+  } catch (e) {
+    console.error("Error parsing yaml");
+    console.error(e.message);
+  }
 
-  const commits: CommitLogObject = await getCommits(config.config.repo.branch);
+  let commits: CommitLogObject;
+  try {
+    commits = await getCommits({
+      localDir: localPath,
+      codeBranch: config.config.repo.branch,
+    });
+  } catch (e) {
+    console.error("Error loading commits:");
+    console.error(e.message);
+    return;
+  }
 
   // Otherwise, continue with the other options
-  const tutorial: T.Tutorial = await parse({
-    text: _markdown,
-    config,
-    commits,
-  });
+  let tutorial: T.Tutorial;
+  try {
+    tutorial = await parse({
+      text: _markdown,
+      config,
+      commits,
+    });
+  } catch (e) {
+    console.error("Error parsing tutorial:");
+    console.error(e.message);
+    return;
+  }
 
   if (tutorial) {
-    if (options.output) {
+    try {
       await write(options.output, JSON.stringify(tutorial), "utf8");
-    } else {
-      console.log(JSON.stringify(tutorial, null, 2));
+    } catch (e) {
+      console.error("Error writing tutorial json:");
+      console.error(e.message);
     }
   }
 }
diff --git a/src/utils/commits.ts b/src/utils/commits.ts
@@ -37,12 +37,26 @@ export async function getCommits({
   const tempGit = gitP(tmpDir);
   await tempGit.clone(localDir, tmpDir);
 
+  const branches = await git.branch();
+
+  if (!branches.all.length) {
+    throw new Error("No branches found");
+  } else if (!branches.all.includes(codeBranch)) {
+    throw new Error(`Code branch "${codeBranch}" not found`);
+  }
+
+  console.log("branches", branches);
+
   // Checkout the code branches
   await git.checkout(codeBranch);
 
+  console.log("checked out");
+
   // Load all logs
   const logs = await git.log();
 
+  console.log("logs", logs);
+
   // Filter relevant logs
   const commits: CommitLogObject = {};
 
@@ -63,6 +77,8 @@ export async function getCommits({
       }
     }
   }
+
+  console.log("remove");
   // cleanup the tmp directory
   await rmdir(tmpDir, { recursive: true });
   return commits;
diff --git a/tests/parse.test.ts b/tests/parse.test.ts
@@ -5,9 +5,9 @@ describe("parse", () => {
   it("should parse summary", () => {
     const md = `# Insert Tutorial's Title here
 
-    Short description to be shown as a tutorial's subtitle.
+Short description to be shown as a tutorial's subtitle.
 
-    `;
+`;
 
     const config = { version: "0.1.0" };
     const result = parse({
