perf(copy): avoid regex in isTypedArray

jbedard · petebacondarwin · commit 19fab4a1d79d · 2015-11-19T08:59:00.000Z
Closes: angular#12054
diff --git a/src/Angular.js b/src/Angular.js
@@ -678,9 +678,9 @@ function isPromiseLike(obj) {
 }
 
 
-var TYPED_ARRAY_REGEXP = /^\[object (Uint8(Clamped)?)|(Uint16)|(Uint32)|(Int8)|(Int16)|(Int32)|(Float(32)|(64))Array\]$/;
+var TYPED_ARRAY_REGEXP = /^\[object (?:Uint8|Uint8Clamped|Uint16|Uint32|Int8|Int16|Int32|Float32|Float64)Array\]$/;
 function isTypedArray(value) {
-  return TYPED_ARRAY_REGEXP.test(toString.call(value));
+  return value && isNumber(value.length) && TYPED_ARRAY_REGEXP.test(toString.call(value));
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -678,9 +678,9 @@ function isPromiseLike(obj) {`
`678`	`678`	`}`
`679`	`679`
`680`	`680`
`681`		`-var TYPED_ARRAY_REGEXP = /^\[object (Uint8(Clamped)?)\|(Uint16)\|(Uint32)\|(Int8)\|(Int16)\|(Int32)\|(Float(32)\|(64))Array\]$/;`
	`681`	`+var TYPED_ARRAY_REGEXP = /^\[object (?:Uint8\|Uint8Clamped\|Uint16\|Uint32\|Int8\|Int16\|Int32\|Float32\|Float64)Array\]$/;`
`682`	`682`	`function isTypedArray(value) {`
`683`		`- return TYPED_ARRAY_REGEXP.test(toString.call(value));`
	`683`	`+ return value && isNumber(value.length) && TYPED_ARRAY_REGEXP.test(toString.call(value));`
`684`	`684`	`}`
`685`	`685`
`686`	`686`