Add React component explicit types, new Webpack config for publicPath

verekia · verekia · commit f0fa0cd7d215 · 2017-03-13T15:36:47.000+08:00
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "js-stack-from-scratch",
-  "version": "2.4.3",
+  "version": "2.4.4",
   "description": "JavaScript Stack from Scratch - Step-by-step tutorial to build a modern JavaScript stack",
   "scripts": {
     "test": "node mdlint.js"
diff --git a/tutorial/04-webpack-react-hmr.md b/tutorial/04-webpack-react-hmr.md
@@ -59,9 +59,9 @@ export default {
     './src/client',
   ],
   output: {
-    filename: 'bundle.js',
-    path: path.resolve(__dirname, 'dist/js'),
-    publicPath: `http://localhost:${WDS_PORT}/dist/js/`,
+    filename: 'js/bundle.js',
+    path: path.resolve(__dirname, 'dist'),
+    publicPath: isProd ? '/static/' : `http://localhost:${WDS_PORT}/dist/`,
   },
   module: {
     rules: [
diff --git a/tutorial/05-redux-immutable-fetch.md b/tutorial/05-redux-immutable-fetch.md
@@ -113,7 +113,12 @@ In this section we are going to create *Components* and *Containers*.
 
 import React, { PropTypes } from 'react'
 
-const Button = ({ label, handleClick }: { label: string, handleClick: Function }) =>
+type Props = {
+  label: string,
+  handleClick: Function,
+}
+
+const Button = ({ label, handleClick }: Props) =>
   <button onClick={handleClick}>{label}</button>
 
 Button.propTypes = {
@@ -133,7 +138,11 @@ export default Button
 
 import React, { PropTypes } from 'react'
 
-const Message = ({ message }: { message: string }) =>
+type Props = {
+  message: string,
+}
+
+const Message = ({ message }: Props) =>
   <p>{message}</p>
 
 Message.propTypes = {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "js-stack-from-scratch",`
`3`		`- "version": "2.4.3",`
	`3`	`+ "version": "2.4.4",`
`4`	`4`	`"description": "JavaScript Stack from Scratch - Step-by-step tutorial to build a modern JavaScript stack",`
`5`	`5`	`"scripts": {`
`6`	`6`	`"test": "node mdlint.js"`