tech(templates): extract sort method

bergquist · bergquist · commit 03fb152d4b32 · 2016-09-13T08:11:04.000+02:00
diff --git a/public/app/features/templating/templateValuesSrv.js b/public/app/features/templating/templateValuesSrv.js
@@ -374,12 +374,20 @@ function (angular, _, $, kbn) {
       }
       options = _.uniq(options, 'value');
 
-      if (variable.sort === 0) {
+      return this.sortVariableValues(options, variable.sort);
+    };
+
+    this.addAllOption = function(variable) {
+      variable.options.unshift({text: 'All', value: "$__all"});
+    };
+
+    this.sortVariableValues = function(options, sortOrder) {
+      if (sortOrder === 0) {
         return options;
       }
 
-      var sortType = Math.ceil(variable.sort / 2);
-      var reverseSort = (variable.sort % 2 === 0);
+      var sortType = Math.ceil(sortOrder / 2);
+      var reverseSort = (sortOrder % 2 === 0);
       if (sortType === 1) {
         options = _.sortBy(options, 'text');
       } else if (sortType === 2) {
@@ -399,10 +407,6 @@ function (angular, _, $, kbn) {
       return options;
     };
 
-    this.addAllOption = function(variable) {
-      variable.options.unshift({text: 'All', value: "$__all"});
-    };
-
   });
 
 });
