ux(dashboard): added more shortcusts to v/edit panel, grafana#6442

torkelo · torkelo · commit 47aae7f1f2ac · 2016-11-02T17:03:14.000+01:00
diff --git a/public/app/core/services/keybindingSrv.ts b/public/app/core/services/keybindingSrv.ts
@@ -105,6 +105,14 @@ export class KeybindingSrv {
       }
     });
 
+    this.bind('v', () => {
+      if (dashboard.meta.focusPanelId) {
+        this.$rootScope.appEvent('panel-change-view', {
+          fullscreen: true, edit: null, panelId: dashboard.meta.focusPanelId
+        });
+      }
+    });
+
     this.bind('d', () => {
       if (dashboard.meta.focusPanelId && dashboard.meta.canEdit) {
         var panelInfo = dashboard.getPanelInfoById(dashboard.meta.focusPanelId);
diff --git a/public/app/features/dashboard/row/add_panel.ts b/public/app/features/dashboard/row/add_panel.ts
@@ -93,6 +93,7 @@ export class AddPanelCtrl {
       isNew: true,
     };
 
+    this.rowCtrl.dropView = 0;
     this.dashboard.addPanel(panel, this.row);
     this.$timeout(() => {
       this.$rootScope.$broadcast('render');
diff --git a/public/app/features/dashboard/row/row_ctrl.ts b/public/app/features/dashboard/row/row_ctrl.ts
@@ -70,6 +70,7 @@ export class DashRowCtrl {
       }
     }
 
+    this.dropView = 0;
     this.row.panelSpanChanged();
     this.$timeout(() => {
       this.$rootScope.$broadcast('render');
diff --git a/public/app/features/dashboard/viewStateSrv.js b/public/app/features/dashboard/viewStateSrv.js
@@ -83,6 +83,13 @@ function (angular, _, $) {
     };
 
     DashboardViewState.prototype.update = function(state) {
+      // implement toggle logic
+      if (this.state.fullscreen && state.fullscreen) {
+        if (this.state.edit === state.edit) {
+          state.fullscreen = !state.fullscreen;
+        }
+      }
+
       // remember if editStateChanged
       this.editStateChanged = state.edit !== this.state.edit;
 

Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,7 @@ export class DashRowCtrl {`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`
	`73`	`+ this.dropView = 0;`
`73`	`74`	`this.row.panelSpanChanged();`
`74`	`75`	`this.$timeout(() => {`
`75`	`76`	`this.$rootScope.$broadcast('render');`