feat(alerting): more aggressive requirements for parsing alertrules

bergquist · bergquist · commit 6121d15ba7b8 · 2016-06-23T16:08:18.000+02:00
diff --git a/pkg/services/alerting/alert_rule.go b/pkg/services/alerting/alert_rule.go
@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"regexp"
 	"strconv"
+	"strings"
 
 	"github.com/grafana/grafana/pkg/components/simplejson"
 	"github.com/grafana/grafana/pkg/services/alerting/transformers"
@@ -63,7 +64,16 @@ func NewAlertRuleFromDBModel(ruleDef *m.Alert) (*AlertRule, error) {
 	model.State = ruleDef.State
 	model.Frequency = ruleDef.Frequency
 
-	model.NotificationGroups = []int64{1, 2}
+	ngs := ruleDef.Settings.Get("notificationGroups").MustString()
+	var ids []int64
+	for _, v := range strings.Split(ngs, ",") {
+		id, err := strconv.Atoi(v)
+		if err == nil {
+			ids = append(ids, int64(id))
+		}
+	}
+
+	model.NotificationGroups = ids
 
 	critical := ruleDef.Settings.Get("crit")
 	model.Critical = Level{
@@ -78,6 +88,10 @@ func NewAlertRuleFromDBModel(ruleDef *m.Alert) (*AlertRule, error) {
 	}
 
 	model.Transform = ruleDef.Settings.Get("transform").Get("type").MustString()
+	if model.Transform == "" {
+		return nil, fmt.Errorf("missing transform")
+	}
+
 	model.TransformParams = *ruleDef.Settings.Get("transform")
 
 	if model.Transform == "aggregation" {
@@ -91,7 +105,6 @@ func NewAlertRuleFromDBModel(ruleDef *m.Alert) (*AlertRule, error) {
 		DatasourceId: query.Get("datasourceId").MustInt64(),
 		From:         query.Get("from").MustString(),
 		To:           query.Get("to").MustString(),
-		Aggregator:   query.Get("agg").MustString(),
 	}
 
 	if model.Query.Query == "" {
diff --git a/pkg/services/alerting/alert_rule_test.go b/pkg/services/alerting/alert_rule_test.go
@@ -55,7 +55,7 @@ func TestAlertRuleModel(t *testing.T) {
 					"datasourceId": 1
 				},
 				"transform": {
-					"method": "avg",
+					"type": "avg",
 					"name": "aggregation"
 				}
 			}
diff --git a/pkg/services/alerting/engine.go b/pkg/services/alerting/engine.go
@@ -132,12 +132,10 @@ func (e *Engine) resultHandler() {
 
 				result.State = alertstates.Critical
 				result.Description = fmt.Sprintf("Failed to run check after %d retires, Error: %v", maxAlertExecutionRetries, result.Error)
-				//e.reactToState(result)
 				e.responseHandler.Handle(result)
 			}
 		} else {
 			result.AlertJob.ResetRetry()
-			//e.reactToState(result)
 			e.responseHandler.Handle(result)
 		}
 	}
diff --git a/pkg/services/alerting/extractor_test.go b/pkg/services/alerting/extractor_test.go
@@ -52,8 +52,8 @@ func TestAlertRuleExtraction(t *testing.T) {
               "to": "now"
             },
             "transform": {
-              "method": "avg",
-              "type": "aggregation"
+              "type": "avg",
+              "name": "aggregation"
             },
             "warn": {
               "value": 10,
@@ -87,7 +87,7 @@ func TestAlertRuleExtraction(t *testing.T) {
               "to": "now"
             },
             "transform": {
-              "method": "avg",
+              "type": "avg",
               "name": "aggregation"
             },
             "warn": {
diff --git a/pkg/services/alerting/models.go b/pkg/services/alerting/models.go
@@ -47,7 +47,6 @@ type Level struct {
 type AlertQuery struct {
 	Query        string
 	DatasourceId int64
-	Aggregator   string
 	From         string
 	To           string
 }

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ func TestAlertRuleModel(t *testing.T) {`
`55`	`55`	`"datasourceId": 1`
`56`	`56`	`},`
`57`	`57`	`"transform": {`
`58`		`- "method": "avg",`
	`58`	`+ "type": "avg",`
`59`	`59`	`"name": "aggregation"`
`60`	`60`	`}`
`61`	`61`	`}`
Original file line number	Diff line number	Diff line change
`@@ -132,12 +132,10 @@ func (e *Engine) resultHandler() {`
`132`	`132`
`133`	`133`	`result.State = alertstates.Critical`
`134`	`134`	`result.Description = fmt.Sprintf("Failed to run check after %d retires, Error: %v", maxAlertExecutionRetries, result.Error)`
`135`		`- //e.reactToState(result)`
`136`	`135`	`e.responseHandler.Handle(result)`
`137`	`136`	`}`
`138`	`137`	`} else {`
`139`	`138`	`result.AlertJob.ResetRetry()`
`140`		`- //e.reactToState(result)`
`141`	`139`	`e.responseHandler.Handle(result)`
`142`	`140`	`}`
`143`	`141`	`}`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ type Level struct {`
`47`	`47`	`type AlertQuery struct {`
`48`	`48`	`Query string`
`49`	`49`	`DatasourceId int64`
`50`		`- Aggregator string`
`51`	`50`	`From string`
`52`	`51`	`To string`
`53`	`52`	`}`