feat(elasticsearch): Added support for Missing option (bucket) for terms aggregation, refactoring PR grafana#4244, thx @shanielh

torkelo · torkelo · commit 7b68e6ea3baa · 2016-12-07T12:06:47.000+01:00
diff --git a/public/app/plugins/datasource/elasticsearch/bucket_agg.js b/public/app/plugins/datasource/elasticsearch/bucket_agg.js
@@ -27,6 +27,7 @@ function (angular, _, queryDef) {
 
     $scope.orderByOptions = [];
     $scope.bucketAggTypes = queryDef.bucketAggTypes;
+    $scope.bucketAggTypesHash = _.indexBy(queryDef.bucketAggTypes, 'value');
     $scope.orderOptions = queryDef.orderOptions;
     $scope.sizeOptions = queryDef.sizeOptions;
 
diff --git a/public/app/plugins/datasource/elasticsearch/partials/bucket_agg.html b/public/app/plugins/datasource/elasticsearch/partials/bucket_agg.html
@@ -57,16 +57,23 @@
 			<label class="gf-form-label width-10">Order</label>
 			<metric-segment-model property="agg.settings.order" options="orderOptions" on-change="onChangeInternal()" css-class="width-12"></metric-segment-model>
 		</div>
-
 		<div class="gf-form offset-width-7">
 			<label class="gf-form-label width-10">Size</label>
 			<metric-segment-model property="agg.settings.size" options="sizeOptions" on-change="onChangeInternal()" css-class="width-12"></metric-segment-model>
 		</div>
-
 		<div class="gf-form offset-width-7">
 			<label class="gf-form-label width-10">Order By</label>
 			<metric-segment-model property="agg.settings.orderBy" options="orderByOptions" on-change="onChangeInternal()" css-class="width-12"></metric-segment-model>
 		</div>
+		<div class="gf-form offset-width-7">
+			<label class="gf-form-label width-10">
+				Missing
+				<info-popover mode="right-normal">
+					The missing parameter defines how documents that are missing a value should be treated. By default they will be ignored but it is also possible to treat them as if they had a value
+				</info-popover>
+			</label>
+			<input type="text" class="gf-form-input max-width-12" empty-to-null ng-model="agg.settings.missing" ng-blur="onChangeInternal()" spellcheck='false'>
+		</div>
 	</div>
 
 	<div ng-if="agg.type === 'filters'">
@@ -94,5 +101,3 @@
 	</div>
 
 </div>
-
-
diff --git a/public/app/plugins/datasource/elasticsearch/query_builder.js b/public/app/plugins/datasource/elasticsearch/query_builder.js
@@ -48,6 +48,10 @@ function (queryDef) {
       }
     }
 
+    if (aggDef.settings.missing) {
+      queryNode.terms.missing = aggDef.settings.missing;
+    }
+
     return queryNode;
   };
 
@@ -67,6 +71,10 @@ function (queryDef) {
       esAgg.format = "epoch_millis";
     }
 
+    if (settings.missing) {
+      esAgg.missing = settings.missing;
+    }
+
     return esAgg;
   };
 

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,10 @@ function (queryDef) {`
`48`	`48`	`}`
`49`	`49`	`}`
`50`	`50`
	`51`	`+ if (aggDef.settings.missing) {`
	`52`	`+ queryNode.terms.missing = aggDef.settings.missing;`
	`53`	`+ }`
	`54`	`+`
`51`	`55`	`return queryNode;`
`52`	`56`	`};`
`53`	`57`
`@@ -67,6 +71,10 @@ function (queryDef) {`
`67`	`71`	`esAgg.format = "epoch_millis";`
`68`	`72`	`}`
`69`	`73`
	`74`	`+ if (settings.missing) {`
	`75`	`+ esAgg.missing = settings.missing;`
	`76`	`+ }`
	`77`	`+`
`70`	`78`	`return esAgg;`
`71`	`79`	`};`
`72`	`80`