Skip to content

Commit 80d88d3

Browse files
committed
fix(config): changed default for oauth and allow_sign_up setting, grafana#6928
1 parent 9da4414 commit 80d88d3

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

conf/defaults.ini

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ org_role = Viewer
209209
#################################### Github Auth #########################
210210
[auth.github]
211211
enabled = false
212-
allow_sign_up = false
212+
allow_sign_up = true
213213
client_id = some_id
214214
client_secret = some_secret
215215
scopes = user:email
@@ -222,7 +222,7 @@ allowed_organizations =
222222
#################################### Google Auth #########################
223223
[auth.google]
224224
enabled = false
225-
allow_sign_up = false
225+
allow_sign_up = true
226226
client_id = some_client_id
227227
client_secret = some_client_secret
228228
scopes = https://www.googleapis.com/auth/userinfo.profile https://www.googleapis.com/auth/userinfo.email
@@ -235,7 +235,7 @@ hosted_domain =
235235
#################################### Grafana.net Auth ####################
236236
[auth.grafananet]
237237
enabled = false
238-
allow_sign_up = false
238+
allow_sign_up = true
239239
client_id = some_id
240240
client_secret = some_secret
241241
scopes = user:email
@@ -244,7 +244,7 @@ allowed_organizations =
244244
#################################### Generic OAuth #######################
245245
[auth.generic_oauth]
246246
enabled = false
247-
allow_sign_up = false
247+
allow_sign_up = true
248248
client_id = some_id
249249
client_secret = some_secret
250250
scopes = user:email

conf/sample.ini

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@
194194
#################################### Github Auth ##########################
195195
[auth.github]
196196
;enabled = false
197-
;allow_sign_up = false
197+
;allow_sign_up = true
198198
;client_id = some_id
199199
;client_secret = some_secret
200200
;scopes = user:email,read:org
@@ -207,7 +207,7 @@
207207
#################################### Google Auth ##########################
208208
[auth.google]
209209
;enabled = false
210-
;allow_sign_up = false
210+
;allow_sign_up = true
211211
;client_id = some_client_id
212212
;client_secret = some_client_secret
213213
;scopes = https://www.googleapis.com/auth/userinfo.profile https://www.googleapis.com/auth/userinfo.email
@@ -219,7 +219,7 @@
219219
#################################### Generic OAuth ##########################
220220
[auth.generic_oauth]
221221
;enabled = false
222-
;allow_sign_up = false
222+
;allow_sign_up = true
223223
;client_id = some_id
224224
;client_secret = some_secret
225225
;scopes = user:email,read:org
@@ -232,7 +232,7 @@
232232
#################################### Grafana.net Auth ####################
233233
[auth.grafananet]
234234
;enabled = false
235-
;allow_sign_up = false
235+
;allow_sign_up = true
236236
;client_id = some_id
237237
;client_secret = some_secret
238238
;scopes = user:email

docs/sources/installation/configuration.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,7 @@ example:
289289

290290
[auth.github]
291291
enabled = true
292+
allow_sign_up = true
292293
client_id = YOUR_GITHUB_APP_CLIENT_ID
293294
client_secret = YOUR_GITHUB_APP_CLIENT_SECRET
294295
scopes = user:email
@@ -323,7 +324,7 @@ Grafana instance. For example:
323324
team_ids = 150,300
324325
auth_url = https://github.com/login/oauth/authorize
325326
token_url = https://github.com/login/oauth/access_token
326-
allow_sign_up = false
327+
allow_sign_up = true
327328

328329
### allowed_organizations
329330

@@ -367,7 +368,7 @@ Secret. Specify these in the Grafana configuration file. For example:
367368
auth_url = https://accounts.google.com/o/oauth2/auth
368369
token_url = https://accounts.google.com/o/oauth2/token
369370
allowed_domains = mycompany.com mycompany.org
370-
allow_sign_up = false
371+
allow_sign_up = true
371372

372373
Restart the Grafana back-end. You should now see a Google login button
373374
on the login page. You can now login or sign up with your Google
@@ -394,7 +395,7 @@ browser to access Grafana, but with the prefix path of `/login/generic_oauth`.
394395
token_url =
395396
api_url =
396397
allowed_domains = mycompany.com mycompany.org
397-
allow_sign_up = false
398+
allow_sign_up = true
398399

399400
Set api_url to the resource that returns basic user info.
400401

0 commit comments

Comments
 (0)