Skip to content

Commit f586748

Browse files
committed
tech(elastic): switch to using null.Float for tsdb
1 parent 70dbc4f commit f586748

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

pkg/tsdb/elasticsearch/elasticsearch.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010
"github.com/grafana/grafana/pkg/log"
1111
"github.com/grafana/grafana/pkg/tsdb"
1212

13+
"gopkg.in/guregu/null.v3"
1314
elastic "gopkg.in/olivere/elastic.v3"
1415
)
1516

@@ -187,7 +188,7 @@ func (e *EsExecutor) processDateHistogram(esQuery EsQuery, bucketAgg *elastic.Ag
187188
for i := 0; i < len(esQuery.Metrics); i++ {
188189
mAgg := esQuery.Metrics[i]
189190
if mAgg.Hide == false { //TODO raise error if there is more then one metric visible
190-
var values [][2]*float64
191+
var values tsdb.TimeSeriesPoints
191192
for _, bucket := range bucketAgg.Buckets {
192193
if mAgg.MetricType == "extended_stats" {
193194
//extended, found := bucket.Aggregations.ExtendedStats(mAgg.Id)
@@ -202,15 +203,14 @@ func (e *EsExecutor) processDateHistogram(esQuery EsQuery, bucketAgg *elastic.Ag
202203
} else {
203204
//everything with json key value should work with this
204205
derivative, found := bucket.Aggregations.Derivative(mAgg.Id) //TODO use correct type
205-
var valueRow [2]*float64
206+
var valueRow [2]null.Float
206207
bucketPoint := float64(bucket.Key)
207-
valueRow[1] = &bucketPoint
208+
valueRow[1] = null.NewFloat(bucketPoint, true)
208209
if found && derivative.Value != nil {
209-
valueRow[0] = derivative.Value
210+
valueRow[0] = null.NewFloat(*derivative.Value, true)
210211
} else {
211212
//use doc_count
212-
point := float64(bucket.DocCount)
213-
valueRow[0] = &point
213+
valueRow[0] = null.NewFloat(float64(bucket.DocCount), true)
214214
}
215215
values = append(values, valueRow)
216216
}

0 commit comments

Comments
 (0)