fix(alerting): added confirm modal in UI, when deleting alert

torkelo · torkelo · commit fe4a0a98c1aa · 2016-09-30T13:00:16.000+02:00
diff --git a/pkg/services/alerting/engine.go b/pkg/services/alerting/engine.go
@@ -144,7 +144,6 @@ func (e *Engine) handleResponse(result *EvalContext) {
 		}
 	}()
 
-	e.log.Info("rule", "nil", result.Rule == nil)
 	e.log.Debug("Alert Rule Result", "ruleId", result.Rule.Id, "firing", result.Firing)
 	e.resultHandler.Handle(result)
 }
diff --git a/public/app/features/alerting/alert_tab_ctrl.ts b/public/app/features/alerting/alert_tab_ctrl.ts
@@ -6,6 +6,7 @@ import {QueryPart} from 'app/core/components/query_part/query_part';
 import alertDef from './alert_def';
 import config from 'app/core/config';
 import moment from 'moment';
+import appEvents from 'app/core/app_events';
 
 export class AlertTabCtrl {
   panel: any;
@@ -302,10 +303,20 @@ export class AlertTabCtrl {
   }
 
   delete() {
-    this.alert = this.panel.alert = {enabled: false};
-    this.panel.thresholds = [];
-    this.conditionModels = [];
-    this.panelCtrl.render();
+    appEvents.emit('confirm-modal', {
+      title: 'Delete Alert',
+      text: 'Are you sure you want to delete this alert rule?',
+      text2: 'You need to save dashboard for the delete to take effect',
+      icon: 'fa-trash',
+      yesText: 'Delete',
+      onConfirm: () => {
+        this.alert = this.panel.alert = {enabled: false};
+        this.panel.thresholds = [];
+        this.conditionModels = [];
+        this.panelCtrl.render();
+      }
+    });
+
   }
 
   enable() {

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,6 @@ func (e Engine) handleResponse(result EvalContext) {`
`144`	`144`	`}`
`145`	`145`	`}()`
`146`	`146`
`147`		`- e.log.Info("rule", "nil", result.Rule == nil)`
`148`	`147`	`e.log.Debug("Alert Rule Result", "ruleId", result.Rule.Id, "firing", result.Firing)`
`149`	`148`	`e.resultHandler.Handle(result)`
`150`	`149`	`}`