Skip to content

Commit 9de61ea

Browse files
mitsuhikomitsuhiko
committed
Reviewed all extensions and wrote down notes.
1 parent 312dfb4 commit 9de61ea

File tree

3 files changed

+270
-0
lines changed

3 files changed

+270
-0
lines changed

‎extreview/approved.rst

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
Approved Extensions
2+
===================
3+
4+
This document contains a list of all extensions that were approved and the
5+
date of approval as well as notes. This should make it possible to better
6+
track the extension approval process.
7+
8+
9+
Flask-Babel
10+
-----------
11+
12+
First Approval: 2010-07-23
13+
Last Review: 2010-07-23
14+
Approved version: 0.6
15+
Approved license: BSD
16+
17+
Notes: Developed by the Flask development head
18+
19+
How to improve: add a better long description to the next release
20+
21+
22+
Flask-SQLAlchemy
23+
----------------
24+
25+
First Approval: 2010-07-25
26+
Last Review: 2010-07-25
27+
Approved version: 0.9
28+
Approved license: BSD
29+
30+
Notes: Developed by the Flask development head
31+
32+
How to improve: add a better long description to the next release

‎extreview/listed.rst

Lines changed: 183 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,183 @@
1+
Listed Extensions
2+
=================
3+
4+
This list contains extensions that passed listing. This means the
5+
extension is on the list of extensions on the website. It does not
6+
contain extensions that are approved.
7+
8+
9+
Flask-CouchDB
10+
-------------
11+
12+
Last-Review: 2010-07-25
13+
Reviewed version: 0.2
14+
15+
Would be fine for approval, but the test suite is not part of the sdist
16+
package (missing entry in MANIFEST.in) and the test suite does not respond
17+
to either "make test" or "python setup.py test".
18+
19+
20+
Flask-CouchDBKit
21+
----------------
22+
23+
Last-Review: 2010-07-25
24+
Reviewed Version: 0.2
25+
26+
Would be fine for approval, but the test suite is not part of the sdist
27+
package (missing entry in MANIFEST.in) and the test suite does not respond
28+
to either "make test" or "python setup.py test".
29+
30+
31+
Flask-Creole
32+
------------
33+
34+
Last-Review: 2010-07-25
35+
Reviewed Version: 0.2
36+
37+
Would be fine for approval, but the test suite is not part of the sdist
38+
package (missing entry in MANIFEST.in) and the test suite does not respond
39+
to either "make test" or "python setup.py test". Furthermore the README
40+
file is empty.
41+
42+
43+
flask-csrf
44+
----------
45+
46+
Last-Review: 2010-07-25
47+
Reviewed Version: 0.2
48+
49+
Will not be approved because this is functionality that should be handled
50+
in the form handling systems which is for Flask-WTF already the case.
51+
Also, this implementation only supports one open tab with forms.
52+
53+
Name is not following Flask extension naming rules.
54+
55+
Considered for unlisting.
56+
57+
58+
Flask-Genshi
59+
------------
60+
61+
Last-Review: 2010-07-25
62+
Reviewed Version: 0.3
63+
64+
Would be fine for approval, but the test suite is not part of the sdist
65+
package (missing entry in MANIFEST.in) and the test suite does not respond
66+
to either "make test" or "python setup.py test". Furthermore the long
67+
description is empty. The zip_safe flag is not set to False which is a
68+
requirement for approved extensions.
69+
70+
71+
flask-lesscss
72+
-------------
73+
74+
Last-Review: 2010-07-25
75+
Reviewed Version: 0.9.1
76+
77+
Broken package description, nonconforming package name, does not follow
78+
standard API rules (init_lesscss instead of lesscss).
79+
80+
Considered for unlisting, improved version should release as
81+
"Flask-LessCSS" with a conforming API and fixed packages indices, as well
82+
as a testsuite.
83+
84+
85+
flask-mail
86+
----------
87+
88+
Last-Review: 2010-07-25
89+
Reviewed Version: 0.3.1
90+
91+
Would be fine for approval, but the test suite is not part of the sdist
92+
package (missing entry in MANIFEST.in) and the test suite does not respond
93+
to either "make test" or "python setup.py test". Furthermore the long
94+
description in the package index is a little bit too short.
95+
96+
Package name should be changed to Flask-Mail with the approval to be
97+
consistent, this might also be the change to improve the API if necessary,
98+
but I don't see any big design problems there.
99+
100+
101+
Flask-OAuth
102+
-----------
103+
104+
Last-Review: 2010-07-25
105+
Reviewed Version: 0.9
106+
107+
Short long description, missing tests.
108+
109+
110+
Flask-OpenID
111+
------------
112+
113+
Last-Review: 2010-07-25
114+
Reviewed Version: 1.0.1
115+
116+
Short long description, missing tests.
117+
118+
119+
Flask-Script
120+
------------
121+
122+
Last-Review: 2010-07-25
123+
Reviewed Version: 0.2
124+
125+
Would be fine for approval, but the test suite is not part of the sdist
126+
package (missing entry in MANIFEST.in) and the test suite does not respond
127+
to either "make test" or "python setup.py test".
128+
129+
The upcoming 0.3 release looks promising, could need a longer "long
130+
description" in the package index though.
131+
132+
133+
Flask-Testing
134+
-------------
135+
136+
Last-Review: 2010-07-25
137+
Reviewed Version: 0.2
138+
139+
Would be fine for approval, but the test suite is not part of the sdist
140+
package (missing entry in MANIFEST.in) and the test suite does not respond
141+
to either "make test" or "python setup.py test".
142+
143+
144+
Flask-Themes
145+
------------
146+
147+
Last-Review: 2010-07-25
148+
Reviewed Version: 0.1
149+
150+
Would be fine for approval, but the test suite is not part of the sdist
151+
package (missing entry in MANIFEST.in) and the test suite does not respond
152+
to either "make test" or "python setup.py test".
153+
154+
155+
Flask-Uploads
156+
-------------
157+
158+
Last-Review: 2010-07-25
159+
Reviewed Version: 0.1
160+
161+
Would be fine for approval, but the test suite is not part of the sdist
162+
package (missing entry in MANIFEST.in) and the test suite does not respond
163+
to either "make test" or "python setup.py test".
164+
165+
166+
Flask-WTF
167+
---------
168+
169+
Last-Review: 2010-07-25
170+
Reviewed Version: 0.2.1
171+
172+
Would be fine for approval, but the test suite is not part of the sdist
173+
package (missing entry in MANIFEST.in) and the test suite does not respond
174+
to either "make test" or "python setup.py test".
175+
176+
177+
Flask-XML-RPC
178+
-------------
179+
180+
Last-Review: 2010-07-25
181+
Reviewed Version: 0.2.1
182+
183+
Missing tests, API wise it would be fine for approval.

‎extreview/rejected.rst

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
Rejected Extensions
2+
===================
3+
4+
This is a list of extensions that is currently rejected from listing and
5+
with that also not approved. If an extension ends up here it should
6+
improved to be listed.
7+
8+
9+
Flask-Actions
10+
-------------
11+
12+
Last Review: 2010-07-25
13+
Reviewed version: 0.2
14+
15+
Rejected because of missing description in PyPI, formatting issues with
16+
the documentation (missing headlines, scrollbars etc.) and a general clash
17+
of functionality with the Flask-Script package. Latter should not be a
18+
problem, but the documentation should improve. For listing, the extension
19+
developer should probably discuss the extension on the mailinglist with
20+
others.
21+
22+
Futhermore it also has an egg registered with an invalid filename.
23+
24+
25+
Flask-Jinja2Extender
26+
--------------------
27+
28+
Last Review: 2010-07-25
29+
Reviewed version: 0.1
30+
31+
Usecase not obvious, hacky implementation, does not solve a problem that
32+
could not be solved with Flask itself. I suppose it is to aid other
33+
extensions, but that should be discussed on the mailinglist.
34+
35+
36+
Flask-Markdown
37+
--------------
38+
39+
Last Review: 2010-07-25
40+
Reviewed version: 0.2
41+
42+
Would be great for enlisting but it should follow the API of Flask-Creole.
43+
Besides that, the docstrings are not valid rst (run through rst2html to
44+
see the issue) and it is missing tests. Otherwise fine :)
45+
46+
47+
flask-urls
48+
----------
49+
50+
Last Review: 2010-07-25
51+
Reviewed version: 0.9.2
52+
53+
Broken PyPI index and non-conforming extension name. Due to the small
54+
featureset this was also delisted from the list. It was there previously
55+
before the approval process was introduced.

0 commit comments

Comments
 (0)