Skip to content

Commit 00b5adf

Browse files
committed
Merge pull request scala#4476 from lrytz/noAkkaActors
Remove the akka-actors dependency
2 parents 4210262 + eeace4a commit 00b5adf

File tree

7 files changed

+11
-34
lines changed

7 files changed

+11
-34
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ Once the `publish-core` task has completed on a commit, you can try it out in sb
9797
```
9898
$ sbt
9999
100-
> set resolvers += "pr" at "http://private-repo.typesafe.com/typesafe/scala-pr-validation-snapshots/"
100+
> set resolvers += "pr" at "https://scala-ci.typesafe.com/artifactory/scala-pr-validation-snapshots/"
101101
> set scalaVersion := "<milestone>-<sha7>-SNAPSHOT"
102102
> console
103103
```

build-ant-macros.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,6 @@
597597
<filter token="RELEASE_REPOSITORY" value="${remote.release.repository}" />
598598
<filter token="SNAPSHOT_REPOSITORY" value="${remote.snapshot.repository}" />
599599
<filter token="JLINE_VERSION" value="${jline.version}" />
600-
<filter token="AKKA_ACTOR_VERSION" value="${akka-actor.version.number}" />
601600

602601
<!-- TODO modularize compiler.
603602
<filter token="SCALA_COMPILER_DOC_VERSION" value="${scala-compiler-doc.version.number}" />

build.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -464,9 +464,9 @@ TODO:
464464
<property name="sbt.lib.dir" value="${build-sbt.dir}/${sbt.latest.version}/lib"/>
465465

466466
<property name="sbt.interface.jar" value="${sbt.lib.dir}/interface.jar"/>
467-
<property name="sbt.interface.url" value="http://private-repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/interface/${sbt.latest.version}/jars/interface.jar"/>
467+
<property name="sbt.interface.url" value="http://dl.bintray.com/typesafe/ivy-releases/org.scala-sbt/interface/${sbt.latest.version}/jars/interface.jar"/>
468468
<property name="sbt.interface.src.jar" value="${sbt.src.dir}/compiler-interface-src.jar"/>
469-
<property name="sbt.interface.src.url" value="http://private-repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/compiler-interface/${sbt.latest.version}/jars/compiler-interface-src.jar"/>
469+
<property name="sbt.interface.src.url" value="http://dl.bintray.com/typesafe/ivy-releases/org.scala-sbt/compiler-interface/${sbt.latest.version}/jars/compiler-interface-src.jar"/>
470470

471471

472472
<!-- Additional command line arguments for scalac. They are added to all build targets -->
@@ -555,7 +555,6 @@ TODO:
555555
<echo message="scala-xml.version.number = ${scala-xml.version.number}"/>
556556
<echo message="scala-parser-combinators.version.number = ${scala-parser-combinators.version.number}"/>
557557
<echo message="scala-swing.version.number = ${scala-swing.version.number}"/>
558-
<echo message="akka-actor.version.number = ${akka-actor.version.number}"/>
559558
<echo message="jline.version = ${jline.version}"/>
560559
<echo message="partest.version.number = ${partest.version.number}"/>
561560
<echo message="scalacheck.version.number = ${scalacheck.version.number}"/>
@@ -566,7 +565,6 @@ TODO:
566565
<entry key="scala-xml.version.number" value="${scala-xml.version.number}"/>
567566
<entry key="scala-parser-combinators.version.number" value="${scala-parser-combinators.version.number}"/>
568567
<entry key="scala-swing.version.number" value="${scala-swing.version.number}"/>
569-
<entry key="akka-actor.version.number" value="${akka-actor.version.number}"/>
570568
<entry key="jline.version" value="${jline.version}"/>
571569
<entry key="partest.version.number" value="${partest.version.number}"/>
572570
<entry key="scalacheck.version.number" value="${scalacheck.version.number}"/>

scripts/jobs/integrate/bootstrap

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -72,26 +72,13 @@
7272

7373
# Requirements
7474
# - sbtCmd must point to sbt from sbt-extras
75-
# - ~/.sonatype-curl that consists of user = USER:PASS
76-
# - ~/.m2/settings.xml with credentials for sonatype
77-
# <server>
78-
# <id>private-repo</id>
79-
# <username>jenkinside</username>
80-
# <password></password>
81-
# </server>
82-
# - ~/.credentials (for sonatype)
83-
# realm=Sonatype Nexus Repository Manager
84-
# host=oss.sonatype.org
85-
# user=lamp
86-
# password=
87-
# - ~/.credentials-private-repo for private-repo.typesafe.com, as follows:
88-
# realm=Artifactory Realm
89-
# host=private-repo.typesafe.com
90-
# user=jenkinside
91-
# password=
92-
# - ~/.sbt/0.13/plugins/gpg.sbt with:
75+
# - ~/.sonatype-curl, ~/.m2/settings.xml, ~/.credentials, ~/.credentials-sonatype, ~/.credentials-private-repo
76+
# as defined by https://github.com/scala/scala-jenkins-infra/tree/master/templates/default
77+
# - ~/.sbt/0.13/plugins/gpg.sbt with:
9378
# addSbtPlugin("com.typesafe.sbt" % "sbt-pgp" % "0.8.1")
9479

80+
# Note: private-repo used to be private-repo.typesafe.com. now we're running artifactory on scala-ci.typesafe.com/artifactory
81+
9582

9683
moduleVersioning=${moduleVersioning-"versions.properties"}
9784

@@ -124,7 +111,7 @@ mkdir -p $baseDir/resolutionScratch_
124111

125112
# repo used to publish "locker" scala to (to start the bootstrap)
126113
releaseTempRepoCred="private-repo"
127-
releaseTempRepoUrl=${releaseTempRepoUrl-"http://private-repo.typesafe.com/typesafe/scala-release-temp/"}
114+
releaseTempRepoUrl=${releaseTempRepoUrl-"https://scala-ci.typesafe.com/artifactory/scala-release-temp/"}
128115

129116
# Used below in sbtArgs since we use a dedicated repository to share artifcacts between jobs,
130117
# so we need to configure SBT to use these rather than its default, Maven Central.
@@ -442,8 +429,7 @@ constructUpdatedModuleVersions() {
442429
updatedModuleVersions=("${updatedModuleVersions[@]}" "-Dpartest.version.number=$PARTEST_VER")
443430
updatedModuleVersions=("${updatedModuleVersions[@]}" "-Dscalacheck.version.number=$SCALACHECK_VER")
444431

445-
# allow overriding the akka-actors and jline version using a jenkins build parameter
446-
if [ ! -z "$AKKA_ACTOR_VER" ]; then updatedModuleVersions=("${updatedModuleVersions[@]}" "-Dakka-actor.version.number=$AKKA_ACTOR_VER"); fi
432+
# allow overriding the jline version using a jenkins build parameter
447433
if [ ! -z "$JLINE_VER" ] ; then updatedModuleVersions=("${updatedModuleVersions[@]}" "-Djline.version=$JLINE_VER"); fi
448434

449435
if [ ! -z "$SCALA_BINARY_VER" ]; then updatedModuleVersions=("${updatedModuleVersions[@]}" "-Dscala.binary.version=$SCALA_BINARY_VER"); fi

src/build/maven/scala-library-all-pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,6 @@
5454
<artifactId>scala-swing_@SCALA_BINARY_VERSION@</artifactId>
5555
<version>@SCALA_SWING_VERSION@</version>
5656
</dependency>
57-
<dependency>
58-
<groupId>com.typesafe.akka</groupId>
59-
<artifactId>akka-actor_@SCALA_BINARY_VERSION@</artifactId>
60-
<version>@AKKA_ACTOR_VERSION@</version>
61-
</dependency>
6257
</dependencies>
6358
<developers>
6459
<developer>

tools/binary-repo-lib.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Library to push and pull binary artifacts from a remote repository using CURL.
44

55
remote_urlget="http://repo.typesafe.com/typesafe/scala-sha-bootstrap/org/scala-lang/bootstrap"
6-
remote_urlpush="http://private-repo.typesafe.com/typesafe/scala-sha-bootstrap/org/scala-lang/bootstrap"
6+
remote_urlpush="http://dl.bintray.com/typesafe/scala-sha-bootstrap/org/scala-lang/bootstrap"
77
libraryJar="$(pwd)/lib/scala-library.jar"
88
desired_ext=".desired.sha1"
99
push_jar="$(pwd)/tools/push.jar"

versions.properties

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ scala.binary.version=2.11
2525
scala-xml.version.number=1.0.4
2626
scala-parser-combinators.version.number=1.0.4
2727
scala-swing.version.number=1.0.2
28-
akka-actor.version.number=2.3.10
2928
jline.version=2.12.1
3029

3130
# external modules, used internally (not shipped)

0 commit comments

Comments
 (0)