SI-6685 fixes error handling in typedApply

xeno-by · xeno-by · commit e6441f16e8c8 · 2012-11-30T09:57:44.000+01:00
When MissingClassTagError doesn't lead to an exception, but rather
silently sets an error, we need to bubble the resulting erroneous tree
up the responsibility chain instead of mindlessly typechecking this again.

This wasn't an issue before, because as far as I can guess the
aforementioned error setter was always throwing exceptions in the most
common usage scenarios (therefore the typecheck-again-fail-again
vicious loop wasn't triggered).
diff --git a/src/compiler/scala/tools/nsc/typechecker/Typers.scala b/src/compiler/scala/tools/nsc/typechecker/Typers.scala
@@ -4516,12 +4516,11 @@ trait Typers extends Modes with Adaptations with Tags {
                 // [Eugene] no more MaxArrayDims. ClassTags are flexible enough to allow creation of arrays of arbitrary dimensionality (w.r.t JVM restrictions)
                 val Some((level, componentType)) = erasure.GenericArray.unapply(tpt.tpe)
                 val tagType = List.iterate(componentType, level)(tpe => appliedType(ArrayClass.toTypeConstructor, List(tpe))).last
-                val newArrayApp = atPos(tree.pos) {
+                atPos(tree.pos) {
                   val tag = resolveClassTag(tree.pos, tagType)
                   if (tag.isEmpty) MissingClassTagError(tree, tagType)
-                  else new ApplyToImplicitArgs(Select(tag, nme.newArray), args)
+                  else typed(new ApplyToImplicitArgs(Select(tag, nme.newArray), args))
                 }
-                typed(newArrayApp, mode, pt)
               case Apply(Select(fun, nme.apply), _) if treeInfo.isSuperConstrCall(fun) => //SI-5696
                 TooManyArgumentListsForConstructor(tree)
               case tree1 =>
