Fix for Google Code issue robbiehanson#126 - connectToHost with empty host string

robbiehanson · robbiehanson · commit 8422fae0684b · 2011-12-09T16:30:39.000-08:00
diff --git a/GCD/GCDAsyncSocket.m b/GCD/GCDAsyncSocket.m
@@ -1806,9 +1806,9 @@ - (BOOL)connectToHost:(NSString *)inHost
 		
 		// Check for problems with host parameter
 		
-		if (host == nil)
+		if ([host length] == 0)
 		{
-			NSString *msg = @"Invalid host parameter (nil). Should be a domain name or IP address string.";
+			NSString *msg = @"Invalid host parameter (nil or \"\"). Should be a domain name or IP address string.";
 			err = [[self badParamError:msg] retain];
 			
 			[pool drain];

Original file line number	Diff line number	Diff line change
`@@ -1806,9 +1806,9 @@ - (BOOL)connectToHost:(NSString *)inHost`
`1806`	`1806`
`1807`	`1807`	`// Check for problems with host parameter`
`1808`	`1808`
`1809`		`- if (host == nil)`
	`1809`	`+ if ([host length] == 0)`
`1810`	`1810`	`{`
`1811`		`- NSString *msg = @"Invalid host parameter (nil). Should be a domain name or IP address string.";`
	`1811`	`+ NSString *msg = @"Invalid host parameter (nil or \"\"). Should be a domain name or IP address string.";`
`1812`	`1812`	`err = [[self badParamError:msg] retain];`
`1813`	`1813`
`1814`	`1814`	`[pool drain];`