fix: #28 markdown image title

shaunthegeek · shaunthegeek · commit 4ffe4c25d0cb · 2021-07-12T12:10:43.000+08:00
diff --git a/app/Coding.php b/app/Coding.php
@@ -72,7 +72,10 @@ public function createMarkdownZip($markdown, $path, $markdownFilename): bool|str
         preg_match_all('/!\[\]\((.+)\)/', $markdown, $matches);
         if (!empty($matches)) {
             foreach ($matches[1] as $attachment) {
-                $this->zipArchive->addFile($path . $attachment, $attachment);
+                // markdown image title: ![](images/default.svg "admin")
+                $tmp = explode(' ', $attachment);
+                $filename = $tmp[0];
+                $this->zipArchive->addFile($path . $filename, $filename);
             }
         }
         $this->zipArchive->close();
diff --git a/tests/data/confluence/space1/image-demo_65619.html b/tests/data/confluence/space1/image-demo_65619.html
@@ -63,6 +63,7 @@ <h3 style="text-align: left;" id="helloworld-1.2Whydoweuseit?">1.2 Why do we use
                         data-linked-resource-container-id="65619" data-linked-resource-container-version="4"></span></p>
                 <p>
                 <h2 id="helloworld-第二章">第二章</h2>
+                <a class="confluence-userlink url fn" data-username="admin" href=""><img class="userLogo logo" src="images/icons/profilepics/default.svg" alt="" title="admin"></a>
                 <p>world</p>
                 <p><span class="confluence-embedded-file-wrapper confluence-embedded-manual-size"><img
                         class="confluence-embedded-image" height="250" src="attachments/65619/65623.png"
diff --git a/tests/data/confluence/space1/images/icons/profilepics/default.svg b/tests/data/confluence/space1/images/icons/profilepics/default.svg
@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<svg width="48px" height="48px" viewBox="0 0 48 48" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+    <!-- Generator: Sketch 48.1 (47250) - http://www.bohemiancoding.com/sketch -->
+    <title>Default user</title>
+    <desc>Created with Sketch.</desc>
+    <defs></defs>
+    <g id="Blank-states" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd">
+        <g id="Default-user">
+            <g id="Group">
+                <rect id="Rectangle" fill="#B3BAC5" x="0" y="0" width="48" height="48"></rect>
+                <g id="Group-4-Copy" transform="translate(12.000000, 9.600000)" fill="#F4F5F7">
+                    <circle id="Oval-2" cx="12" cy="7.2" r="7.2"></circle>
+                    <path d="M-2.54658516e-11,29.3888903 C3.28703506,32.023876 7.45945579,33.6 12,33.6 C16.5405442,33.6 20.7129649,32.023876 24,29.3888903 L24,19.2003876 C24,17.8752024 22.9304288,16.8 21.6110458,16.8 L2.38895416,16.8 C1.07785486,16.8 5.03561637e-12,17.8752119 5.03561637e-12,19.201553 L5.03561637e-12,29.3888903 Z" id="Oval-10" fill-rule="nonzero"></path>
+                </g>
+            </g>
+        </g>
+    </g>
+</svg>

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,10 @@ public function createMarkdownZip($markdown, $path, $markdownFilename): bool\|str`
`72`	`72`	`preg_match_all('/!\[\]\((.+)\)/', $markdown, $matches);`
`73`	`73`	`if (!empty($matches)) {`
`74`	`74`	`foreach ($matches[1] as $attachment) {`
`75`		`- $this->zipArchive->addFile($path . $attachment, $attachment);`
	`75`	`+ // markdown image title: ![](images/default.svg "admin")`
	`76`	`+ $tmp = explode(' ', $attachment);`
	`77`	`+ $filename = $tmp[0];`
	`78`	`+ $this->zipArchive->addFile($path . $filename, $filename);`
`76`	`79`	`}`
`77`	`80`	`}`
`78`	`81`	`$this->zipArchive->close();`