Skip to content

Commit 9917bcf

Browse files
committed
fix: #40 env useless
1 parent eba0fe6 commit 9917bcf

File tree

2 files changed

+22
-3
lines changed

2 files changed

+22
-3
lines changed

config/coding.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,7 @@
66
'project_uri' => env('CODING_PROJECT_URI'),
77
'import' => [
88
'provider' => env('CODING_IMPORT_PROVIDER'),
9+
'data_type' => env('CODING_IMPORT_DATA_TYPE'),
10+
'data_path' => env('CODING_IMPORT_DATA_PATH'),
911
],
1012
];

tests/Feature/WikiImportCommandTest.php

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public function testHandleShow()
5454
config(['confluence.password' => $this->faker->password]);
5555
$codingToken = $this->faker->md5;
5656
config(['coding.token' => $codingToken]);
57-
$codingTeamDomain = $this->faker->domainWord;
57+
$codingTeamDomain = $this->faker->domainWord;
5858
config(['coding.team_domain' => $codingTeamDomain]);
5959
$codingProjectUri = $this->faker->slug;
6060
config(['coding.project_uri' => $codingProjectUri]);
@@ -125,7 +125,7 @@ public function testHandleConfluenceHtmlFileNotExist()
125125
{
126126
$codingToken = $this->faker->md5;
127127
config(['coding.token' => $codingToken]);
128-
$codingTeamDomain = $this->faker->domainWord;
128+
$codingTeamDomain = $this->faker->domainWord;
129129
config(['coding.team_domain' => $codingTeamDomain]);
130130
$codingProjectUri = $this->faker->slug;
131131
config(['coding.project_uri' => $codingProjectUri]);
@@ -149,7 +149,7 @@ public function testHandleConfluenceHtmlSuccess()
149149
{
150150
$codingToken = $this->faker->md5;
151151
config(['coding.token' => $codingToken]);
152-
$codingTeamDomain = $this->faker->domainWord;
152+
$codingTeamDomain = $this->faker->domainWord;
153153
config(['coding.team_domain' => $codingTeamDomain]);
154154
$codingProjectUri = $this->faker->slug;
155155
config(['coding.project_uri' => $codingProjectUri]);
@@ -193,4 +193,21 @@ public function testHandleConfluenceHtmlSuccess()
193193
->expectsOutput('上传成功,正在处理,任务 ID:a12353fa-f45b-4af2-83db-666bf9f66615')
194194
->assertExitCode(0);
195195
}
196+
197+
public function testAskNothing()
198+
{
199+
$codingToken = $this->faker->md5;
200+
config(['coding.token' => $codingToken]);
201+
$codingTeamDomain = $this->faker->domainWord;
202+
config(['coding.team_domain' => $codingTeamDomain]);
203+
$codingProjectUri = $this->faker->slug;
204+
config(['coding.project_uri' => $codingProjectUri]);
205+
config(['coding.import.provider' => 'Confluence']);
206+
// TODO config function can set the key not exists, can't test the key not exists in config file
207+
config(['coding.import.data_type' => 'HTML']);
208+
config(['coding.import.data_path' => '/dev/null']);
209+
$this->artisan('wiki:import')
210+
->expectsOutput('文件不存在:/dev/null/index.html')
211+
->assertExitCode(1);
212+
}
196213
}

0 commit comments

Comments
 (0)