feat: #13 change function name and test

shaunthegeek · shaunthegeek · commit 833612c54616 · 2021-12-28T15:26:27.000+08:00
diff --git a/src/ProjectSetting.php b/src/ProjectSetting.php
@@ -15,12 +15,12 @@ public function getIssueTypes(array $data)
         return $response['IssueTypes'];
     }
 
-    public function getIssueStatus(array $data)
+    public function getIssueStatuses(array $data)
     {
         $this->validate($data, [
             'ProjectName' => 'string|required',
             'IssueType' => [
-                'required',
+                'required_without:IssueTypeId',
                 Rule::in(Issue::TYPE),
             ],
             'IssueTypeId' => 'nullable|integer',
diff --git a/tests/Acceptance/ProjectSettingTest.php b/tests/Acceptance/ProjectSettingTest.php
@@ -0,0 +1,19 @@
+<?php
+
+namespace Tests\Acceptance;
+
+use Coding\Core;
+use Coding\ProjectSetting;
+
+class ProjectSettingTest extends TestCase
+{
+    public function testGetIssueStatuses()
+    {
+        $projectSetting = new ProjectSetting($this->token);
+        $result = $projectSetting->getIssueStatuses([
+            'ProjectName' => $this->projectName,
+            'IssueType' => 'DEFECT',
+        ]);
+        $this->assertEquals('DEFECT', $result[0]['IssueType']);
+    }
+}
diff --git a/tests/Unit/ProjectSettingTest.php b/tests/Unit/ProjectSettingTest.php
@@ -27,7 +27,7 @@ public function testGetIssueTypes()
         $this->assertEquals($response['IssueTypes'], $result);
     }
 
-    public function testGetIssueStatus()
+    public function testGetIssueStatuses()
     {
         $response = json_decode(
             file_get_contents($this->dataPath('DescribeProjectIssueStatusListResponse.json')),
@@ -44,7 +44,7 @@ public function testGetIssueStatus()
         ])->andReturn($response);
 
         $projectSetting = new ProjectSetting($this->token, $this->coreMock);
-        $result = $projectSetting->getIssueStatus($data);
+        $result = $projectSetting->getIssueStatuses($data);
         $this->assertEquals($response['ProjectIssueStatusList'], $result);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -15,12 +15,12 @@ public function getIssueTypes(array $data)`
`15`	`15`	`return $response['IssueTypes'];`
`16`	`16`	`}`
`17`	`17`
`18`		`- public function getIssueStatus(array $data)`
	`18`	`+ public function getIssueStatuses(array $data)`
`19`	`19`	`{`
`20`	`20`	`$this->validate($data, [`
`21`	`21`	`'ProjectName' => 'string\|required',`
`22`	`22`	`'IssueType' => [`
`23`		`- 'required',`
	`23`	`+ 'required_without:IssueTypeId',`
`24`	`24`	`Rule::in(Issue::TYPE),`
`25`	`25`	`],`
`26`	`26`	`'IssueTypeId' => 'nullable\|integer',`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public function testGetIssueTypes()`
`27`	`27`	`$this->assertEquals($response['IssueTypes'], $result);`
`28`	`28`	`}`
`29`	`29`
`30`		`- public function testGetIssueStatus()`
	`30`	`+ public function testGetIssueStatuses()`
`31`	`31`	`{`
`32`	`32`	`$response = json_decode(`
`33`	`33`	`file_get_contents($this->dataPath('DescribeProjectIssueStatusListResponse.json')),`
`@@ -44,7 +44,7 @@ public function testGetIssueStatus()`
`44`	`44`	`])->andReturn($response);`
`45`	`45`
`46`	`46`	`$projectSetting = new ProjectSetting($this->token, $this->coreMock);`
`47`		`- $result = $projectSetting->getIssueStatus($data);`
	`47`	`+ $result = $projectSetting->getIssueStatuses($data);`
`48`	`48`	`$this->assertEquals($response['ProjectIssueStatusList'], $result);`
`49`	`49`	`}`
`50`	`50`	`}`