Removing uneccessary args extraction. Just accept options.

gregbell · gregbell · commit c3464a7a0db2 · 2012-03-07T07:57:30.000-08:00
diff --git a/lib/active_admin/views/components/batch_action_form.rb b/lib/active_admin/views/components/batch_action_form.rb
@@ -6,8 +6,7 @@ class BatchActionForm < ActiveAdmin::Component
       
       attr_reader :prefix_html
       
-      def build(*args, &block)
-        options = args.extract_options!
+      def build(options = {}, &block)
         options[:id] ||= "collection_selection"
         @contents = input(:name => :batch_action, :id => :batch_action, :type => :hidden)
         @prefix_html = text_node(form_tag active_admin_config.batch_action_path, :id => options[:id])
diff --git a/lib/active_admin/views/components/batch_action_popover.rb b/lib/active_admin/views/components/batch_action_popover.rb
@@ -5,15 +5,13 @@ module Views
     # Build an BatchActionPopover
     class BatchActionPopover < ActiveAdmin::Views::ActionListPopover
       builder_method :batch_action_popover
-      
-      def build(*args, &block)
-        options = args.extract_options!
+
+      def build(options = {}, &block)
         options[:id] ||= "batch_actions_popover"
         super(options)
       end
-      
-      def action(batch_action, *args)
-        options = args.extract_options!
+
+      def action(batch_action, options = {})
         options[:class] ||= []
         options[:class] += %w(batch_action)
         super( "%s Selected" % batch_action.title, "#", options.merge( "data-action" => batch_action.sym, "data-confirm" => batch_action.confirm ) )
diff --git a/lib/active_admin/views/components/popover.rb b/lib/active_admin/views/components/popover.rb
@@ -8,9 +8,7 @@ def default_class_name
         'popover'
       end
       
-      def build(*args, &block)
-        
-        options = args.extract_options!
+      def build(options = {}, &block)
         
         self.id = options[:id]
         
@@ -33,4 +31,4 @@ def add_child(child)
       
     end
   end
-end
+end
