fix(common): fix a Closure compilation issue.

mprobst · alxhub · commit 2e7e935b0287 · 2017-12-15T07:51:30.000-08:00
Closure Compiler cannot infer that the swtich statement is exhaustive,
which causes it to complain that the method does not always return a
value.

Work around the problem by throwing an exception in the default case,
and using the `: never` type to ensure the code is unreachable.
diff --git a/packages/common/src/i18n/format_date.ts b/packages/common/src/i18n/format_date.ts
@@ -270,6 +270,13 @@ function getDateTranslation(
       return getLocaleDayPeriods(locale, form, <TranslationWidth>width)[currentHours < 12 ? 0 : 1];
     case TranslationType.Eras:
       return getLocaleEraNames(locale, <TranslationWidth>width)[date.getFullYear() <= 0 ? 0 : 1];
+    default:
+      // This default case is not needed by TypeScript compiler, as the switch is exhaustive.
+      // However Closure Compiler does not understand that and reports an error in typed mode.
+      // The `throw new Error` below works around the problem, and the unexpected: never variable
+      // makes sure tsc still checks this code is unreachable.
+      const unexpected: never = name;
+      throw new Error(`unexpected translation type ${unexpected}`);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -270,6 +270,13 @@ function getDateTranslation(`
`270`	`270`	`return getLocaleDayPeriods(locale, form, <TranslationWidth>width)[currentHours < 12 ? 0 : 1];`
`271`	`271`	`case TranslationType.Eras:`
`272`	`272`	`return getLocaleEraNames(locale, <TranslationWidth>width)[date.getFullYear() <= 0 ? 0 : 1];`
	`273`	`+ default:`
	`274`	`+ // This default case is not needed by TypeScript compiler, as the switch is exhaustive.`
	`275`	`+ // However Closure Compiler does not understand that and reports an error in typed mode.`
	`276`	+ // The `throw new Error` below works around the problem, and the unexpected: never variable
	`277`	`+ // makes sure tsc still checks this code is unreachable.`
	`278`	`+ const unexpected: never = name;`
	`279`	+ throw new Error(`unexpected translation type ${unexpected}`);
`273`	`280`	`}`
`274`	`281`	`}`
`275`	`282`