Skip to content

Commit 0766841

Browse files
authored
Merge pull request Shopify#65 from Shopify/update_shopify_api
Updating shopify-api to v1.0.1
2 parents 523c388 + c425692 commit 0766841

File tree

3 files changed

+42
-23
lines changed

3 files changed

+42
-23
lines changed

app/Lib/CookieHandler.php

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
namespace App\Lib;
6+
7+
use Illuminate\Support\Facades\Cookie;
8+
use Shopify\Auth\OAuthCookie;
9+
use Shopify\Context;
10+
11+
class CookieHandler
12+
{
13+
public static function saveShopifyCookie(OAuthCookie $cookie)
14+
{
15+
Cookie::queue(
16+
$cookie->getName(),
17+
$cookie->getValue(),
18+
$cookie->getExpire() ? ceil(($cookie->getExpire() - time()) / 60) : null,
19+
'/',
20+
Context::$HOST_NAME,
21+
$cookie->isSecure(),
22+
$cookie->isHttpOnly(),
23+
false,
24+
'Lax'
25+
);
26+
27+
return true;
28+
}
29+
}

composer.lock

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

routes/web.php

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
use App\Models\Session;
44
use Illuminate\Http\Request;
55
use Illuminate\Http\Response;
6-
use Illuminate\Support\Facades\Cookie;
76
use Illuminate\Support\Facades\Log;
87
use Illuminate\Support\Facades\Route;
98
use Shopify\Auth\OAuth;
@@ -65,27 +64,18 @@
6564
$shop,
6665
'/auth/callback',
6766
true,
68-
function (Shopify\Auth\OAuthCookie $cookie) {
69-
Cookie::queue(
70-
$cookie->getName(),
71-
$cookie->getValue(),
72-
ceil(($cookie->getExpire() - time()) / 60),
73-
'/',
74-
Context::$HOST_NAME,
75-
$cookie->isSecure(),
76-
$cookie->isHttpOnly(),
77-
false,
78-
'Lax'
79-
);
80-
return true;
81-
}
67+
['App\Lib\CookieHandler', 'saveShopifyCookie'],
8268
);
8369

8470
return redirect($installUrl);
8571
});
8672

8773
Route::get('/auth/callback', function (Request $request) {
88-
$session = OAuth::callback($request->cookie(), $request->query());
74+
$session = OAuth::callback(
75+
$request->cookie(),
76+
$request->query(),
77+
['App\Lib\CookieHandler', 'saveShopifyCookie'],
78+
);
8979

9080
$host = $request->query('host');
9181
$shop = Utils::sanitizeShopDomain($request->query('shop'));

0 commit comments

Comments
 (0)