Replace / endpoint with fallback

paulomarg · paulomarg · commit 9f41fe6a43cc · 2021-05-20T10:39:30.000-04:00
diff --git a/routes/web.php b/routes/web.php
@@ -26,7 +26,7 @@
 |
 */
 
-Route::get('/', function (Request $request) {
+Route::fallback(function (Request $request) {
     $shop = Utils::sanitizeShopDomain($request->query('shop'));
     $host = $request->query('host');
     $appInstalled = Session::where('shop', $shop)->exists();
diff --git a/tests/Feature/RootTest.php b/tests/Feature/RootTest.php
@@ -33,4 +33,20 @@ public function testReturn200IfShopIsAlreadyInstalled()
         $response->assertStatus(200);
         $response->assertViewIs('react');
     }
+
+    public function testUncaughtRequestsTriggerRouteBehaviour()
+    {
+        $session = new Session(
+            "test-session-id",
+            "test-shop.myshopify.io",
+            false,
+            "test-session-state"
+        );
+
+        Context::$SESSION_STORAGE->storeSession($session);
+
+        $response = $this->get("/not-a-real-endpoint?shop=test-shop.myshopify.io");
+        $response->assertStatus(200);
+        $response->assertViewIs('react');
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@`
`26`	`26`	`\|`
`27`	`27`	`*/`
`28`	`28`
`29`		`-Route::get('/', function (Request $request) {`
	`29`	`+Route::fallback(function (Request $request) {`
`30`	`30`	`$shop = Utils::sanitizeShopDomain($request->query('shop'));`
`31`	`31`	`$host = $request->query('host');`
`32`	`32`	`$appInstalled = Session::where('shop', $shop)->exists();`