Skip to content

Commit a3e972e

Browse files
committed
refine DataIO
1 parent c8ad603 commit a3e972e

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

bindings/support/DataIO.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ namespace py = pybind11;
99

1010
class PyBDataIO : public BDataIO {
1111
public:
12+
using BDataIO::BDataIO;
1213
ssize_t Read(void* buffer, size_t size) override {
1314
PYBIND11_OVERLOAD(ssize_t, BDataIO, Read, buffer, size);
1415
}
@@ -23,8 +24,8 @@ class PyBDataIO : public BDataIO {
2324

2425
class PyBPositionIO : public BPositionIO {
2526
public:
26-
using BPositionIO::Seek;
27-
using BPositionIO::Position;
27+
// using BPositionIO::Seek;
28+
// using BPositionIO::Position;
2829
using BPositionIO::BPositionIO;
2930
ssize_t Read(void* buffer, size_t size) override {
3031
PYBIND11_OVERLOAD(ssize_t, BPositionIO, Read, buffer, size);
@@ -54,6 +55,7 @@ class PyBPositionIO : public BPositionIO {
5455

5556
class PyBMemoryIO : public BMemoryIO {
5657
public:
58+
using BMemoryIO::BMemoryIO;
5759
ssize_t ReadAt(off_t position, void* buffer, size_t size) override {
5860
PYBIND11_OVERLOAD(ssize_t, BMemoryIO, ReadAt, position, buffer, size);
5961
}
@@ -73,6 +75,7 @@ class PyBMemoryIO : public BMemoryIO {
7375

7476
class PyBMallocIO : public BMallocIO {
7577
public:
78+
using BMallocIO::BMallocIO;
7679
ssize_t ReadAt(off_t position, void* buffer, size_t size) override {
7780
PYBIND11_OVERLOAD(ssize_t, BMallocIO, ReadAt, position, buffer, size);
7881
}
@@ -108,7 +111,6 @@ py::class_<BMemoryIO,PyBMemoryIO, BPositionIO>(m, "BMemoryIO");
108111
py::class_<BMallocIO,PyBMallocIO, BPositionIO>(m, "BMallocIO");
109112
*/
110113
py::class_<BPositionIO, PyBPositionIO, BDataIO>(m, "BPositionIO")
111-
//py::class_<PyBPositionIO, std::shared_ptr<PyBPositionIO>>(m, "BPositionIO")
112114
.def(py::init(), "")
113115
.def("Read", &BPositionIO::Read, "", py::arg("buffer"), py::arg("size"))
114116
.def("Write", &BPositionIO::Write, "", py::arg("buffer"), py::arg("size"))
@@ -123,7 +125,6 @@ py::class_<BPositionIO, PyBPositionIO, BDataIO>(m, "BPositionIO")
123125
;
124126

125127
py::class_<BMemoryIO, PyBMemoryIO, BPositionIO>(m, "BMemoryIO")
126-
//py::class_<PyBMemoryIO, std::shared_ptr<PyBMemoryIO>>(m, "BMemoryIO")
127128
//.def(py::init<void *, size_t>(), "", py::arg("data"), py::arg("length"))
128129
//.def(py::init<const void *, size_t>(), "", py::arg("data"), py::arg("length"))
129130
.def("ReadAt", &BMemoryIO::ReadAt, "", py::arg("position"), py::arg("buffer"), py::arg("size"))

0 commit comments

Comments
 (0)