Skip to content

Commit 5fa0abd

Browse files
committed
Use lock in both index and remove operation.
1 parent 70294bc commit 5fa0abd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

vm/src/builtins/list.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -300,8 +300,8 @@ impl PyList {
300300

301301
if let Some(index) = index.into() {
302302
// defer delete out of borrow
303-
let mut elements = self.borrow_vec_mut();
304-
Ok((index < elements.len()).then(move || elements.remove(index)))
303+
let is_inside_range = index < self.borrow_vec().len();
304+
Ok(is_inside_range.then(|| self.borrow_vec_mut().remove(index)))
305305
} else {
306306
Err(vm.new_value_error(format!("'{}' is not in list", needle.str(vm)?)))
307307
}

0 commit comments

Comments
 (0)