Subrange in KafkaConsumer::pollMessages()

Jørgen Fogh · kenneth-jia · commit 28e7b2712bb6 · 2021-10-27T15:26:21.000+08:00
The `std::for_each` in `KafkaConsumer::pollMessages()` should not copy the whole buffer, only the received messages.
diff --git a/include/kafka/KafkaConsumer.h b/include/kafka/KafkaConsumer.h
@@ -817,7 +817,7 @@ KafkaConsumer::pollMessages(int timeoutMs, std::vector<consumer::ConsumerRecord>
     // Wrap messages with ConsumerRecord
     output.clear();
     output.reserve(msgReceived);
-    std::for_each(msgPtrArray.begin(), msgPtrArray.end(), [&output](rd_kafka_message_t* rkMsg) { output.emplace_back(rkMsg); });
+    std::for_each(msgPtrArray.begin(), msgPtrArray.begin() + msgReceived, [&output](rd_kafka_message_t* rkMsg) { output.emplace_back(rkMsg); });
 
     // Store the offsets for all these polled messages (for "enable.auto.commit=true" case)
     storeOffsetsIfNecessary(output);
