Remove pthread lib dependency from windows/macOS

kenneth-jia · kenneth-jia · commit d7ccbee76fb4 · 2021-11-19T17:55:44.000+08:00
diff --git a/.github/workflows/kafka_api_ci_tests.yml b/.github/workflows/kafka_api_ci_tests.yml
@@ -266,11 +266,6 @@ jobs:
           cp -v "C:\VCPKG\INSTALLED\x86-windows\lib\manual-link\gtest_main*" "C:\VCPKG\INSTALLED\x86-windows\lib\"
           cp -v "C:\VCPKG\INSTALLED\x86-windows\lib\manual-link\gtest_main*" "C:\VCPKG\INSTALLED\x86-windows\lib\"
 
-          # Install pthread
-          vcpkg install pthread
-          cp -v "C:\VCPKG\INSTALLED\x86-windows\lib\pthreadVC3.lib" "C:\VCPKG\INSTALLED\x86-windows\lib\pthread.lib"
-          cp -v "C:\VCPKG\INSTALLED\x86-windows\bin\pthreadVC3.dll" "C:\VCPKG\INSTALLED\x86-windows\bin\pthread.dll"
-
           # Install boost headers/libraries
           vcpkg install boost-optional
           vcpkg install boost-algorithm
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -32,13 +32,15 @@ message(STATUS "librdkafka library directory: ${LIBRDKAFKA_LIBRARY_DIR}")
 
 
 #---------------------------
-# Check pthread library
+# Check pthread library (for linux only)
 #---------------------------
-find_library(PTHREAD_LIB pthread)
-if (PTHREAD_LIB)
-    message(STATUS "pthread library: ${PTHREAD_LIB}")
-else ()
-    message(FATAL_ERROR "Could not find library: pthread!")
+if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
+    find_library(PTHREAD_LIB pthread)
+    if (PTHREAD_LIB)
+        message(STATUS "pthread library: ${PTHREAD_LIB}")
+    else ()
+        message(FATAL_ERROR "Could not find library: pthread!")
+    endif ()
 endif ()
 
 
diff --git a/include/CMakeLists.txt b/include/CMakeLists.txt
@@ -14,7 +14,9 @@ target_link_libraries(${PROJECT_NAME} INTERFACE rdkafka)
 #---------------------------
 # pthread
 #---------------------------
-target_link_libraries(${PROJECT_NAME} INTERFACE pthread)
+if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
+    target_link_libraries(${PROJECT_NAME} INTERFACE pthread)
+endif ()
 
 #---------------------------
 # sasl (if required)
