feat(supported-version): add all kind (#36)

damienwebdev · web-flow · commit 26c354d8d4d1 · 2022-08-12T08:40:31.000-04:00
diff --git a/.github/workflows/_internal-install.yaml b/.github/workflows/_internal-install.yaml
@@ -29,13 +29,16 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./supported-version
+        with:
+          kind: all
         id: supported-version
       - run: echo ${{ steps.supported-version.outputs.matrix }}
 
   install-test:
     needs: compute_matrix
     strategy:
       matrix: ${{ fromJSON(needs.compute_matrix.outputs.matrix) }}
+      fail-fast: false
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v3
diff --git a/.github/workflows/_internal-integration.yaml b/.github/workflows/_internal-integration.yaml
@@ -29,6 +29,8 @@ jobs:
       steps:
         - uses: actions/checkout@v3
         - uses: ./supported-version
+          with:
+            kind: all
           id: supported-version
         - run: echo ${{ steps.supported-version.outputs.matrix }}
   integration-workflow:
@@ -39,3 +41,4 @@ jobs:
       source_folder: $GITHUB_WORKSPACE/_test/demo-package
       matrix: ${{ needs.compute_matrix.outputs.matrix }}
       test_command: ../../../vendor/bin/phpunit ../../../vendor/graycore/magento2-demo-package/Test/Integration
+      fail-fast: false
diff --git a/supported-version/README.md b/supported-version/README.md
@@ -13,7 +13,7 @@ See the [action.yml](./action.yml)
 
 | Input           | Description                                                                                                                                                  | Required | Default     |
 | --------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------ | -------- | ----------- |
-| kind            | The "kind" of support you're targeting for your package. Allowed values are `currently-supported`, `latest` and `custom`                                     | false    | 'currently-supported' |
+| kind            | The "kind" of support you're targeting for your package. Allowed values are `currently-supported`, `latest`, `custom`, and `all`                                     | false    | 'currently-supported' |
 | custom_versions | The versions you want to support, as a comma-separated string, i.e. 'magento/project-community-edition:2.3.7-p3, magento/project-community-edition:2.4.2-p2' | false    | ''          |
 
 ## Usage
diff --git a/supported-version/action.yml b/supported-version/action.yml
@@ -5,7 +5,7 @@ description: "A Github Action that computes the Github Actions matrix for the ch
 inputs:
   kind:
     required: false
-    description: "The kind of versions you want to return. Allowed values are `currently-supported, latest, custom`"
+    description: "The kind of versions you want to return. Allowed values are `currently-supported, latest, custom, all`"
     default: "currently-supported"
   custom_versions:
     required: false
diff --git a/supported-version/dist/index.js b/supported-version/dist/index.js
diff --git a/supported-version/src/kind/compute-kind.ts b/supported-version/src/kind/compute-kind.ts
@@ -5,6 +5,7 @@ export const KNOWN_KINDS = {
     'currently-supported': true,
     'latest': true,
     'custom': true,
+    'all': true,
 }
 
 export const isValidKind = (kind: string): boolean => {
diff --git a/supported-version/src/matrix/get-matrix-for-kind.spec.ts b/supported-version/src/matrix/get-matrix-for-kind.spec.ts
@@ -15,6 +15,13 @@ describe('getMatrixForKind', () => {
         expect(result.include).toBeDefined();
     });
 
+    it('returns a matrix for `all`', () => {
+        const result = getMatrixForKind("all");
+
+        expect(result.magento).toBeDefined();
+        expect(result.include).toBeDefined();
+    });
+
     it('returns a matrix for valid `custom`', () => {
         const result = getMatrixForKind("custom", "magento/project-community-edition:2.3.7-p3");
 
diff --git a/supported-version/src/matrix/get-matrix-for-kind.ts b/supported-version/src/matrix/get-matrix-for-kind.ts
@@ -2,13 +2,16 @@ import { getMatrixForVersions } from "./get-matrix-for-versions";
 
 import latestJson from '../kind/latest.json';
 import currentlySupportedJson from '../kind/currently-supported.json';
+import allVersions from '../versions/individual.json';
 
 export const getMatrixForKind = (kind: string, versions: string = "") => {
     switch(kind){
         case 'latest': 
           return getMatrixForVersions(latestJson);
         case 'currently-supported':
           return getMatrixForVersions(currentlySupportedJson);
+        case 'all':
+          return getMatrixForVersions(Object.keys(allVersions));
         case 'custom':
           return getMatrixForVersions(versions.split(","))
         default:

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ export const KNOWN_KINDS = {`
`5`	`5`	`'currently-supported': true,`
`6`	`6`	`'latest': true,`
`7`	`7`	`'custom': true,`
	`8`	`+ 'all': true,`
`8`	`9`	`}`
`9`	`10`
`10`	`11`	`export const isValidKind = (kind: string): boolean => {`