Skip to content

✨start ArrayNamespace #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

✨start ArrayNamespace #56

wants to merge 9 commits into from
+680 −346

Conversation

nstarman
Copy link
Collaborator

relies on #34

@nstarman
💄rearrange protocols in Array
3cb0930 
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman
✨ HasDevice
377b4b5 
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman
✨ HasMatrixTranspose
ce758bd
@nstarman
✨ HasNDim
c6b28ad 
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman
✨ HasShape
b99cb83
@nstarman
✨ HasSize
697883d 
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
@nstarman
✨ HasTranspose
c65c5d5 
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman
✨ start ArrayNamespace protocol
466b4f7 
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman nstarman added this to the v2021-12-0.0 milestone Aug 22, 2025
@nstarman
✨: AsType functions
a17798c 
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman nstarman requested a review from jorenham August 22, 2025 18:15
nstarman
nstarman commented Aug 22, 2025
View reviewed changes
src/array_api_typing/_array_docstrings.json
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These empty files snuck in. I'll remove when rebasing after #34 is in.

@nstarman
Copy link
Collaborator Author

nstarman commented Aug 22, 2025 •
edited
Loading

@jorenham @NeilGirdhar pinging for your thoughts on the structure of ArrayNamespace.
The idea is to have a DoesX protocol for each function, then a HasX that says that a namespace has that function, thenArrayNamespace is just the intersection of all those HasX.
This enables granular typing of each function, the minimum supporting namespace, and of course the full Array API namespace behemoth.

https://github.com/data-apis/array-api-typing/pull/56/files/c65c5d54c358dbda72af916eea89b17943a08835..a17798c2db03bed6633253977ab51108211d0809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorenham jorenham Awaiting requested review from jorenham

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2021-12-0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@nstarman