Move to separate method to have ability re-register hooks

KostyaSha · KostyaSha · commit c98e36f64c20 · 2015-03-27T22:30:41.000+03:00
diff --git a/src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java b/src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java
@@ -141,27 +141,31 @@ public Set<GitHubRepositoryName> getGitHubRepositories() {
     public void start(AbstractProject<?,?> project, boolean newInstance) {
         super.start(project, newInstance);
         if (newInstance && getDescriptor().isManageHook()) {
-            // make sure we have hooks installed. do this lazily to avoid blocking the UI thread.
-            final Collection<GitHubRepositoryName> names = GitHubRepositoryNameContributor.parseAssociatedNames(job);
-
-            getDescriptor().queue.execute(new Runnable() {
-                public void run() {
-                    LOGGER.log(Level.INFO, "Adding GitHub webhooks for {0}", names);
-
-                    for (GitHubRepositoryName name : names) {
-                        for (GHRepository repo : name.resolve()) {
-                            try {
-                                if(createJenkinsHook(repo, getDescriptor().getHookUrl())) {
-                                    break;
-                                }
-                            } catch (Throwable e) {
-                                LOGGER.log(Level.WARNING, "Failed to add GitHub webhook for "+name, e);
+            registerHooks();
+        }
+    }
+
+    public void registerHooks() {
+        // make sure we have hooks installed. do this lazily to avoid blocking the UI thread.
+        final Collection<GitHubRepositoryName> names = GitHubRepositoryNameContributor.parseAssociatedNames(job);
+
+        getDescriptor().queue.execute(new Runnable() {
+            public void run() {
+                LOGGER.log(Level.INFO, "Adding GitHub webhooks for {0}", names);
+
+                for (GitHubRepositoryName name : names) {
+                    for (GHRepository repo : name.resolve()) {
+                        try {
+                            if(createJenkinsHook(repo, getDescriptor().getHookUrl())) {
+                                break;
                             }
+                        } catch (Throwable e) {
+                            LOGGER.log(Level.WARNING, "Failed to add GitHub webhook for "+name, e);
                         }
                     }
                 }
-            });
-        }
+            }
+        });
     }
 
     private boolean createJenkinsHook(GHRepository repo, URL url) {
