perf(cdk): adjust default frameFrate and frame budget computation

hoebbelsB · hoebbelsB · commit e66f169ffc01 · 2021-09-09T16:24:04.000+02:00
diff --git a/libs/cdk/internals/scheduler/src/lib/scheduler.ts b/libs/cdk/internals/scheduler/src/lib/scheduler.ts
@@ -419,6 +419,9 @@ function forceFrameRate(fps) {
     // reset the framerate
     yieldInterval = 5;
   }
+  // be aware of browser housekeeping work (~6ms per frame)
+  // according to https://developers.google.com/web/fundamentals/performance/rendering
+  yieldInterval = Math.max(5, yieldInterval - 6);
 }
 
 const performWorkUntilDeadline = () => {
diff --git a/libs/cdk/src/lib/render-strategies/concurrent-strategies.ts b/libs/cdk/src/lib/render-strategies/concurrent-strategies.ts
@@ -14,7 +14,9 @@ import {
 } from '../model';
 import { coalescingManager } from '@rx-angular/cdk/coalescing';
 
-forceFrameRate(60);
+// set default to 30fps, actually matching other frameworks defaults:
+// https://github.com/WICG/scheduling-apis/blob/main/misc/userspace-schedulers.md#appendix-scheduler-case-studies
+forceFrameRate(30);
 
 const noPriorityStrategy: RxStrategyCredentials = {
   name: 'noPriority',

Original file line number	Diff line number	Diff line change
`@@ -419,6 +419,9 @@ function forceFrameRate(fps) {`
`419`	`419`	`// reset the framerate`
`420`	`420`	`yieldInterval = 5;`
`421`	`421`	`}`
	`422`	`+ // be aware of browser housekeeping work (~6ms per frame)`
	`423`	`+ // according to https://developers.google.com/web/fundamentals/performance/rendering`
	`424`	`+ yieldInterval = Math.max(5, yieldInterval - 6);`
`422`	`425`	`}`
`423`	`426`
`424`	`427`	`const performWorkUntilDeadline = () => {`