feat(is): throw error if component selector does not have name

eddyerburgh · eddyerburgh · commit ad6af6f42f49 · 2017-07-16T14:43:21.000+01:00
diff --git a/src/wrappers/wrapper.js b/src/wrappers/wrapper.js
@@ -206,7 +206,9 @@ export default class Wrapper implements BaseWrapper {
       if (!this.isVueComponent) {
         return false
       }
-      // TODO: Throw error if component does not have name
+      if (typeof selector.name !== 'string') {
+        throwError('a Component used as a selector must have a name property')
+      }
       return vmCtorMatchesName(this.vm, selector.name)
     }
     return this.element.getAttribute && this.element.matches(selector)
diff --git a/test/integration/specs/mount/Wrapper/is.spec.js b/test/integration/specs/mount/Wrapper/is.spec.js
@@ -52,6 +52,15 @@ describe('is', () => {
     expect(wrapper.is('#p')).to.equal(false)
   })
 
+  it('throws error if component passed to use as identifier does not have a name', () => {
+    const compiled = compileToFunctions('<div />')
+    const wrapper = mount(compiled)
+
+    const message = '[vue-test-utils]: a Component used as a selector must have a name property'
+    const fn = () => wrapper.is({ render: () => {} })
+    expect(fn).to.throw().with.property('message', message)
+  })
+
   it('throws an error if selector is not a valid selector', () => {
     const compiled = compileToFunctions('<div />')
     const wrapper = mount(compiled)

Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,9 @@ export default class Wrapper implements BaseWrapper {`
`206`	`206`	`if (!this.isVueComponent) {`
`207`	`207`	`return false`
`208`	`208`	`}`
`209`		`- // TODO: Throw error if component does not have name`
	`209`	`+ if (typeof selector.name !== 'string') {`
	`210`	`+ throwError('a Component used as a selector must have a name property')`
	`211`	`+ }`
`210`	`212`	`return vmCtorMatchesName(this.vm, selector.name)`
`211`	`213`	`}`
`212`	`214`	`return this.element.getAttribute && this.element.matches(selector)`