Fix: nw.App.clearCache hang and it should be sync

rogerwang · rogerwang · commit 0cfb681602bd · 2016-04-09T21:20:52.000+08:00
Ref nwjs#4674
diff --git a/src/api/nw_app_api.cc b/src/api/nw_app_api.cc
@@ -109,7 +109,10 @@ bool NwAppClearCacheFunction::RunNWSync(base::ListValue* response, std::string*
                   BrowsingDataRemover::REMOVE_CACHE,
                   BrowsingDataHelper::ALL);
   // BrowsingDataRemover deletes itself.
+  base::MessageLoop::ScopedNestableTaskAllower allow(
+        base::MessageLoop::current());
   run_loop_.Run();
+  remover->RemoveObserver(this);
   return true;
 }
 
diff --git a/src/resources/api_nw_app.js b/src/resources/api_nw_app.js
@@ -56,6 +56,9 @@ nw_binding.registerCustomHook(function(bindingsAPI) {
   apiFunctions.setHandleRequest('setProxyConfig', function() {
     sendRequest.sendRequestSync('nw.App.setProxyConfig', arguments, this.definition.parameters, {});
   });
+  apiFunctions.setHandleRequest('clearCache', function() {
+    sendRequest.sendRequestSync('nw.App.clearCache', arguments, this.definition.parameters, {});
+  });
   apiFunctions.setHandleRequest('getProxyForURL', function() {
     return nwNatives.getProxyForURL.apply(this, arguments);
   });
