fix: extractCSS should only be applied to styles (vuejs#811)

HerringtonDarkholme · yyx990803 · commit 26a5c93ad54e · 2017-05-13T16:20:23.000+08:00
diff --git a/lib/loader.js b/lib/loader.js
@@ -213,7 +213,7 @@ module.exports = function (content) {
       }
     }
 
-    var loader = options.extractCSS
+    var loader = options.extractCSS && type === 'styles'
       ? loaders[lang] || getCSSExtractLoader(lang)
       : loaders[lang]
 
diff --git a/test/test.js b/test/test.js
@@ -166,6 +166,32 @@ describe('vue-loader', function () {
     })
   })
 
+  it('pre-processors with extract css', done => {
+    test({
+      entry: './test/fixtures/pre.vue',
+      vue: {
+        extractCSS: true
+      },
+      plugins: [
+        new ExtractTextPlugin('test.output.css')
+      ]
+    }, (window, module) => {
+      var vnode = mockRender(module)
+
+      expect(vnode.children[0].tag).to.equal('h1')
+      expect(vnode.children[1].tag).to.equal('comp-a')
+      expect(vnode.children[2].tag).to.equal('comp-b')
+
+      expect(module.data().msg).to.contain('Hello from coffee!')
+
+      var css = mfs.readFileSync('/test.output.css').toString()
+      css = normalizeNewline(css)
+      expect(css).to.contain('body {\n  font: 100% Helvetica, sans-serif;\n  color: #999;\n}')
+
+      done()
+    })
+  })
+
   it('scoped style', done => {
     test({
       entry: './test/fixtures/scoped-css.vue',

Original file line number	Diff line number	Diff line change
`@@ -213,7 +213,7 @@ module.exports = function (content) {`
`213`	`213`	`}`
`214`	`214`	`}`
`215`	`215`
`216`		`- var loader = options.extractCSS`
	`216`	`+ var loader = options.extractCSS && type === 'styles'`
`217`	`217`	`? loaders[lang] \|\| getCSSExtractLoader(lang)`
`218`	`218`	`: loaders[lang]`
`219`	`219`