tsup for stack-shared (stack-auth#647)

N2D4 · web-flow · commit c25abaaa32bc · 2025-04-28T21:26:52.000-07:00
diff --git a/apps/backend/.eslintrc.cjs b/apps/backend/.eslintrc.cjs
@@ -1,8 +1,8 @@
-const defaults = require("../../eslint-configs/defaults.js");
-const publicVars = require("../../eslint-configs/extra-rules.js");
+const defaults = require("../../configs/eslint/defaults.js");
+const publicVars = require("../../configs/eslint/extra-rules.js");
 
 module.exports = {
-  extends: ["../../eslint-configs/defaults.js", "../../eslint-configs/next.js"],
+  extends: ["../../configs/eslint/defaults.js", "../../configs/eslint/next.js"],
   ignorePatterns: ["/*", "!/src", "!/scripts", "!/prisma"],
   rules: {
     "no-restricted-syntax": [
diff --git a/apps/backend/prisma/tsup.config.ts b/apps/backend/prisma/tsup.config.ts
@@ -1,4 +1,15 @@
 import { defineConfig } from 'tsup';
+import { createBasePlugin } from '../../../configs/tsup/plugins';
+
+const customNoExternal = new Set([
+  '@stackframe/stack-shared',
+  '@prisma/client',
+  '@prisma/extension-accelerate',
+  'jose',
+  'yup',
+  'json-diff',
+  'svix',
+]);
 
 // tsup config to build the self-hosting seed script so it can be
 // run in the Docker container with no extra dependencies.
@@ -8,6 +19,9 @@ export default defineConfig({
   outDir: 'dist',
   target: 'node22',
   platform: 'node',
-  noExternal: ['@stackframe/stack-shared', '@prisma/client', '@prisma/extension-accelerate', 'jose', 'yup', 'json-diff'],
-  clean: true
+  noExternal: [...customNoExternal],
+  clean: true,
+  esbuildPlugins: [
+    createBasePlugin({ customNoExternal }),
+  ],
 });
diff --git a/apps/dashboard/.eslintrc.cjs b/apps/dashboard/.eslintrc.cjs
@@ -1,8 +1,8 @@
-const defaults = require("../../eslint-configs/defaults.js");
-const publicVars = require("../../eslint-configs/extra-rules.js");
+const defaults = require("../../configs/eslint/defaults.js");
+const publicVars = require("../../configs/eslint/extra-rules.js");
 
 module.exports = {
-  extends: ["../../eslint-configs/defaults.js", "../../eslint-configs/next.js"],
+  extends: ["../../configs/eslint/defaults.js", "../../configs/eslint/next.js"],
   ignorePatterns: ["/*", "!/src", "!/prisma"],
   rules: {
     "no-restricted-imports": [
diff --git a/apps/e2e/.eslintrc.cjs b/apps/e2e/.eslintrc.cjs
@@ -1,6 +1,6 @@
 module.exports = {
   "extends": [
-    "../../eslint-configs/defaults.js",
+    "../../configs/eslint/defaults.js",
   ],
   "ignorePatterns": ['/*', '!/tests'],
   "rules": {
diff --git a/apps/mcp-server/.eslintrc.cjs b/apps/mcp-server/.eslintrc.cjs
@@ -1,7 +1,7 @@
 module.exports = {
   "extends": [
-    "../../eslint-configs/defaults.js",
-    "../../eslint-configs/next.js",
+    "../../configs/eslint/defaults.js",
+    "../../configs/eslint/next.js",
   ],
   "ignorePatterns": ['/*', '!/src']
 };
diff --git a/apps/mock-oauth-server/.eslintrc.js b/apps/mock-oauth-server/.eslintrc.js
@@ -1,7 +1,7 @@
 module.exports = {
   "extends": [
-    "../../eslint-configs/defaults.js",
-    "../../eslint-configs/next.js",
+    "../../configs/eslint/defaults.js",
+    "../../configs/eslint/next.js",
   ],
   "ignorePatterns": ['/*', '!/src']
 };
diff --git a/configs/eslint/defaults.js b/configs/eslint/defaults.js
diff --git a/configs/eslint/extra-rules.js b/configs/eslint/extra-rules.js
diff --git a/configs/eslint/next.js b/configs/eslint/next.js
diff --git a/configs/tsup/js-library.ts b/configs/tsup/js-library.ts
@@ -0,0 +1,22 @@
+import { defineConfig } from 'tsup';
+import { createBasePlugin } from './plugins';
+
+const customNoExternal = new Set([
+  "oauth4webapi",
+]);
+
+export default function createJsLibraryTsupConfig(options: { barrelFile: boolean }) {
+  return defineConfig({
+    entryPoints: ['src/**/*.(ts|tsx|js|jsx)'],
+    sourcemap: true,
+    clean: false,
+    noExternal: [...customNoExternal],
+    dts: options.barrelFile ? 'src/index.ts' : true,  // we only generate types for the barrel file because it drastically decreases the memory needed for tsup https://github.com/egoist/tsup/issues/920#issuecomment-2454732254
+    outDir: 'dist',
+    format: ['esm', 'cjs'],
+    legacyOutput: true,
+    esbuildPlugins: [
+      createBasePlugin({ customNoExternal }),
+    ],
+  });
+}
diff --git a/configs/tsup/plugins.ts b/configs/tsup/plugins.ts
@@ -0,0 +1,45 @@
+import type { Plugin } from "esbuild";
+import fs from 'fs';
+import path from "path";
+
+export const createBasePlugin = (options: { customNoExternal: Set<string> }): Plugin => {
+  const packageJson = JSON.parse(fs.readFileSync("./package.json", "utf-8"));
+  return {
+    name: 'stackframe tsup plugin (private)',
+    setup(build) {
+      build.onEnd(result => {
+        const sourceFiles = result.outputFiles?.filter(file => !file.path.endsWith('.map')) ?? [];
+        for (const file of sourceFiles) {
+          let newText = file.text;
+
+          // make sure "use client" is at the top of the file
+          const matchUseClient = /[\s\n\r]*(^|\n|\r|;)\s*['"]use\s+client['"]\s*(\n|\r|;)/im;
+          if (matchUseClient.test(file.text)) {
+            newText = `"use client";\n${file.text}`;
+          }
+
+          file.contents = new TextEncoder().encode(newText);
+        }
+      });
+
+      build.onResolve({ filter: /^.*$/m }, async (args) => {
+        if (args.kind === "entry-point" || options.customNoExternal.has(args.path)) {
+          return undefined;
+        }
+        return {
+          external: true,
+        };
+      });
+
+      build.onLoad({ filter: /\.(jsx?|tsx?)$/ }, async (args) => {
+        let contents = await fs.promises.readFile(args.path, 'utf8');
+        contents = contents.replace(/STACK_COMPILE_TIME_CLIENT_PACKAGE_VERSION_SENTINEL/g, `js ${packageJson.name}@${packageJson.version}`);
+        contents = contents.replace(/import\.meta\.vitest/g, 'undefined');
+        return {
+          contents,
+          loader: path.extname(args.path).slice(1) as 'js' | 'jsx' | 'ts' | 'tsx'
+        };
+      });
+    },
+  }
+}
diff --git a/docker/server/Dockerfile b/docker/server/Dockerfile
@@ -38,6 +38,7 @@ COPY --from=pruner /app/out/pnpm-lock.yaml .
 COPY .gitignore .
 COPY pnpm-workspace.yaml .
 COPY turbo.json .
+COPY configs ./configs
 RUN cat ./pnpm-lock.yaml
 RUN --mount=type=cache,id=pnpm,target=/pnpm/store STACK_SKIP_TEMPLATE_GENERATION=true pnpm install --frozen-lockfile
 
diff --git a/examples/demo/.eslintrc.js b/examples/demo/.eslintrc.js
@@ -1,7 +1,7 @@
 module.exports = {
   "extends": [
-    "../../eslint-configs/defaults.js",
-    "../../eslint-configs/next.js",
+    "../../configs/eslint/defaults.js",
+    "../../configs/eslint/next.js",
   ],
   "ignorePatterns": ['/*', '!/src'],
   rules: {
diff --git a/examples/docs-examples/.eslintrc.js b/examples/docs-examples/.eslintrc.js
@@ -1,5 +1,5 @@
 module.exports = {
-  extends: ["../../eslint-configs/defaults.js", "../../eslint-configs/next.js"],
+  extends: ["../../configs/eslint/defaults.js", "../../configs/eslint/next.js"],
   ignorePatterns: ["/*", "!/src"],
   rules: {
     "@typescript-eslint/no-misused-promises": [0],
diff --git a/examples/e-commerce/.eslintrc.js b/examples/e-commerce/.eslintrc.js
@@ -1,7 +1,7 @@
 module.exports = {
   "extends": [
-    "../../eslint-configs/defaults.js",
-    "../../eslint-configs/next.js",
+    "../../configs/eslint/defaults.js",
+    "../../configs/eslint/next.js",
   ],
   "ignorePatterns": ['/*', '!/src'],
   rules: {
diff --git a/examples/middleware/.eslintrc.js b/examples/middleware/.eslintrc.js
@@ -1,7 +1,7 @@
 module.exports = {
   "extends": [
-    "../../eslint-configs/defaults.js",
-    "../../eslint-configs/next.js",
+    "../../configs/eslint/defaults.js",
+    "../../configs/eslint/next.js",
   ],
   "ignorePatterns": ['/*', '!/src']
 };
diff --git a/examples/partial-prerendering/.eslintrc.js b/examples/partial-prerendering/.eslintrc.js
@@ -1,7 +1,7 @@
 module.exports = {
   "extends": [
-    "../../eslint-configs/defaults.js",
-    "../../eslint-configs/next.js",
+    "../../configs/eslint/defaults.js",
+    "../../configs/eslint/next.js",
   ],
   "ignorePatterns": ['/*', '!/src']
 };
diff --git a/package.json b/package.json
@@ -82,7 +82,8 @@
     "turbo": "^2.2.3",
     "typescript": "5.3.3",
     "vitest": "^1.6.0",
-    "wait-on": "^8.0.1"
+    "wait-on": "^8.0.1",
+    "esbuild": "^0.24.0"
   },
   "pnpm": {
     "overrides": {
diff --git a/packages/init-stack/.eslintrc.cjs b/packages/init-stack/.eslintrc.cjs
@@ -1,6 +1,6 @@
 module.exports = {
   "extends": [
-    "../../eslint-configs/defaults.js",
+    "../../configs/eslint/defaults.js",
   ],
   "ignorePatterns": ['/*', '!/src'],
 };
diff --git a/packages/stack-emails/.eslintrc.cjs b/packages/stack-emails/.eslintrc.cjs
@@ -1,6 +1,6 @@
 module.exports = {
   "extends": [
-    "../../eslint-configs/defaults.js",
+    "../../configs/eslint/defaults.js",
   ],
   "ignorePatterns": ['/*', '!/src'],
 };
diff --git a/packages/stack-sc/.eslintrc.cjs b/packages/stack-sc/.eslintrc.cjs
@@ -1,6 +1,6 @@
 module.exports = {
   "extends": [
-    "../../eslint-configs/defaults.js",
+    "../../configs/eslint/defaults.js",
   ],
   "ignorePatterns": ['/*', '!/src'],
 };
diff --git a/packages/stack-shared/.eslintrc.cjs b/packages/stack-shared/.eslintrc.cjs
@@ -1,6 +1,6 @@
 module.exports = {
   "extends": [
-    "../../eslint-configs/defaults.js",
+    "../../configs/eslint/defaults.js",
   ],
   "ignorePatterns": ['/*', '!/src'],
 };
diff --git a/packages/stack-shared/package.json b/packages/stack-shared/package.json
@@ -5,11 +5,11 @@
   "types": "./dist/index.d.ts",
   "type": "module",
   "scripts": {
-    "build": "tsc",
+    "build": "rimraf dist && tsup-node",
     "typecheck": "tsc --noEmit",
     "test": "vitest run",
     "clean": "rimraf dist && rimraf node_modules",
-    "dev": "tsc -w --preserveWatchOutput --declarationMap",
+    "dev": "tsup-node --watch",
     "lint": "eslint --ext .tsx,.ts ."
   },
   "files": [
@@ -21,11 +21,11 @@
   "exports": {
     ".": {
       "types": "./dist/index.d.ts",
-      "default": "./dist/index.js"
+      "default": "./dist/esm/index.js"
     },
     "./dist/*": {
       "types": "./dist/*.d.ts",
-      "default": "./dist/*.js"
+      "default": "./dist/esm/*.js"
     }
   },
   "peerDependencies": {
diff --git a/packages/stack-shared/src/utils/api-keys.tsx b/packages/stack-shared/src/utils/api-keys.tsx
@@ -1,7 +1,7 @@
-import { getBase32CharacterFromIndex } from "@stackframe/stack-shared/dist/utils/bytes";
-import { generateSecureRandomString } from "@stackframe/stack-shared/dist/utils/crypto";
-import { StackAssertionError } from "@stackframe/stack-shared/dist/utils/errors";
 import crc32 from 'crc/crc32';
+import { getBase32CharacterFromIndex } from "./bytes";
+import { generateSecureRandomString } from "./crypto";
+import { StackAssertionError } from "./errors";
 
 
 const STACK_AUTH_MARKER = "574ck4u7h";
diff --git a/packages/stack-shared/src/utils/promises.tsx b/packages/stack-shared/src/utils/promises.tsx
@@ -301,7 +301,7 @@ export function runAsynchronouslyWithAlert(...args: Parameters<typeof runAsynchr
     {
       ...args[1],
       onError: error => {
-        if (error instanceof KnownError && process.env.NODE_ENV.includes("production")) {
+        if (error instanceof KnownError && typeof process !== "undefined" && (process.env.NODE_ENV as any)?.includes("production")) {
           alert(error.message);
         } else {
           alert(`An unhandled error occurred. Please ${process.env.NODE_ENV === "development" ? `check the browser console for the full error.` : "report this to the developer."}\n\n${error}`);
diff --git a/packages/stack-shared/tsup.config.ts b/packages/stack-shared/tsup.config.ts
@@ -0,0 +1,3 @@
+import createJsLibraryTsupConfig from '../../configs/tsup/js-library';
+
+export default createJsLibraryTsupConfig({ barrelFile: false });
diff --git a/packages/stack-ui/.eslintrc.cjs b/packages/stack-ui/.eslintrc.cjs
@@ -1,6 +1,6 @@
 module.exports = {
   "extends": [
-    "../../eslint-configs/defaults.js",
+    "../../configs/eslint/defaults.js",
   ],
   "ignorePatterns": ['/*', '!/src'],
 };
diff --git a/packages/template/.eslintrc.cjs b/packages/template/.eslintrc.cjs
@@ -1,8 +1,8 @@
-const defaults = require("../../eslint-configs/defaults.js");
+const defaults = require("../../configs/eslint/defaults.js");
 
 module.exports = {
   "extends": [
-    "../../eslint-configs/defaults.js",
+    "../../configs/eslint/defaults.js",
   ],
   "ignorePatterns": ['/*', '!/src'],
   "rules": {
diff --git a/packages/template/tsup.config.ts b/packages/template/tsup.config.ts
@@ -1,56 +1,3 @@
-import fs from 'fs';
-import path from 'path';
-import { defineConfig, Options } from 'tsup';
+import createJsLibraryTsupConfig from '../../configs/tsup/js-library';
 
-const customNoExternal = new Set([
-  "oauth4webapi",
-]);
-
-const packageJson = JSON.parse(fs.readFileSync(path.join(__dirname, 'package.json'), 'utf-8'));
-
-const config: Options = {
-  entryPoints: ['src/**/*.(ts|tsx|js|jsx)'],
-  sourcemap: true,
-  clean: false,
-  noExternal: [...customNoExternal],
-  dts: 'src/index.ts',  // we only generate types for the barrel file because it drastically decreases the memory needed for tsup https://github.com/egoist/tsup/issues/920#issuecomment-2454732254
-  outDir: 'dist',
-  format: ['esm', 'cjs'],
-  legacyOutput: true,
-  esbuildPlugins: [
-    {
-      name: 'stackframe tsup plugin (private)',
-      setup(build) {
-        build.onEnd(result => {
-          const sourceFiles = result.outputFiles?.filter(file => !file.path.endsWith('.map')) ?? [];
-          for (const file of sourceFiles) {
-            const matchUseClient = /[\s\n\r]*(^|\n|\r|;)\s*['"]use\s+client['"]\s*(\n|\r|;)/im;
-            if (matchUseClient.test(file.text)) {
-              file.contents = new TextEncoder().encode(`"use client";\n${file.text}`);
-            }
-          }
-        });
-
-        build.onResolve({ filter: /^.*$/m }, async (args) => {
-          if (args.kind === "entry-point" || customNoExternal.has(args.path)) {
-            return undefined;
-          }
-          return {
-            external: true,
-          };
-        });
-
-        build.onLoad({ filter: /\.(jsx?|tsx?)$/ }, async (args) => {
-          let contents = await fs.promises.readFile(args.path, 'utf8');
-          contents = contents.replace(/STACK_COMPILE_TIME_CLIENT_PACKAGE_VERSION_SENTINEL/g, `js ${packageJson.name}@${packageJson.version}`);
-          return {
-            contents,
-            loader: path.extname(args.path).slice(1) as 'js' | 'jsx' | 'ts' | 'tsx'
-          };
-        });
-      },
-    },
-  ],
-};
-
-export default defineConfig(config);
+export default createJsLibraryTsupConfig({ barrelFile: true });
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
