refactor 238

fishercoder1534 · fishercoder1534 · commit b81456891e39 · 2017-09-12T21:33:40.000-07:00
diff --git a/src/main/java/com/fishercoder/solutions/_238.java b/src/main/java/com/fishercoder/solutions/_238.java
@@ -15,26 +15,30 @@
 
 public class _238 {
 
-    /**Very straightforward idea: iterate through the array twice:
-     * first time: get res[i] = res[i-1]*nums[i-1]
-     * second time: have a variable called right, which means all the numbers product to its right, then do
-     * res[i] *= right;
-     * right *= nums[i];
-     * that's it.
-
-     * This could be very well illustrated with this example: [1,2,3,4]*/
-    public int[] productExceptSelf(int[] nums) {
-        int n = nums.length;
-        int[] result = new int[n];
-        result[0] = 1;
-        for (int i = 1; i < n; i++) {
-            result[i] = result[i - 1] * nums[i - 1];
-        }
-        int right = 1;
-        for (int i = n - 1; i >= 0; i--) {
-            result[i] *= right;
-            right *= nums[i];
+    public static class Solution1 {
+        /**
+         * Very straightforward idea: iterate through the array twice:
+         * first time: get res[i] = res[i-1]*nums[i-1]
+         * second time: have a variable called right, which means all the numbers product to its right, then do
+         * res[i] *= right;
+         * right *= nums[i];
+         * that's it.
+         * <p>
+         * This could be very well illustrated with this example: [1,2,3,4]
+         */
+        public int[] productExceptSelf(int[] nums) {
+            int n = nums.length;
+            int[] result = new int[n];
+            result[0] = 1;
+            for (int i = 1; i < n; i++) {
+                result[i] = result[i - 1] * nums[i - 1];
+            }
+            int right = 1;
+            for (int i = n - 1; i >= 0; i--) {
+                result[i] *= right;
+                right *= nums[i];
+            }
+            return result;
         }
-        return result;
     }
 }
diff --git a/src/test/java/com/fishercoder/_238Test.java b/src/test/java/com/fishercoder/_238Test.java
@@ -8,14 +8,14 @@
 import static org.junit.Assert.assertArrayEquals;
 
 public class _238Test {
-    private static _238 test;
+    private static _238.Solution1 solution1;
     private static int[] expected;
     private static int[] actual;
     private static int[] nums;
 
     @BeforeClass
     public static void setup() {
-        test = new _238();
+        solution1 = new _238.Solution1();
     }
 
     @Before
@@ -28,23 +28,23 @@ public void setupForEachTest() {
     public void test1() {
         nums = new int[]{0, 0};
         expected = new int[]{0, 0};
-        actual = test.productExceptSelf(nums);
+        actual = solution1.productExceptSelf(nums);
         assertArrayEquals(expected, actual);
     }
 
     @Test
     public void test2() {
         nums = new int[]{1, 0};
         expected = new int[]{0, 1};
-        actual = test.productExceptSelf(nums);
+        actual = solution1.productExceptSelf(nums);
         assertArrayEquals(expected, actual);
     }
 
     @Test
     public void test3() {
         nums = new int[]{1, 2, 3, 4};
         expected = new int[]{24, 12, 8, 6};
-        actual = test.productExceptSelf(nums);
+        actual = solution1.productExceptSelf(nums);
         assertArrayEquals(expected, actual);
     }
 }
