Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: msgpack/msgpack-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: devendor/msgpack-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 13 commits
  • 1 file changed
  • 2 contributors

Commits on Sep 28, 2018

  1. travis: Run test on Python 3.4 (#307) 

    Python 3.4 is not supported officially.
But keep running test for a while, to know when msgpack-python
stop working on Python 3.4 actually.
    @methane @devendor
    methane authored and devendor committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    6494e91 View commit details
    Browse the repository at this point in the history

  2. Rolls back legacy python and jython fixes in favor of implicit type 

    casting.

The current patches did not work under jython-2.7.1 where implicit
casting of buffer or memoryview doesn't work. It may also be the
jython is a little pickier about string casting non string bytes
due to the underlying strong typing of java.

See issues #303 & #304.

Rolls back / replaces:
aa41e2f
5f684ae
b10cf78
    @devendor
    devendor committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    88a8904 View commit details
    Browse the repository at this point in the history

  3. Reverts jython and legacy python / _buffer_view changes.

    @devendor
    devendor committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    7b0e41c View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'remotes/origin/devendor_legacy_fallback' 

    Replace jython and legacy cpython fixes with explicit type casting.
    @devendor
    devendor committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    5ea4d26 View commit details
    Browse the repository at this point in the history

  5. Fix original patch.

    @devendor
    devendor committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    2baaf7b View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2018

  1. Another shot to pass py3 tests.

    @devendor
    devendor committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    394b339 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2018

  1. move _unpack_from to global function.

    @devendor
    devendor committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    ea0065f View commit details
    Browse the repository at this point in the history

  2. fix failed test.

    @devendor
    devendor committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    3b60399 View commit details
    Browse the repository at this point in the history

  3. fix failed test.

    @devendor
    devendor committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    b86a1b8 View commit details
    Browse the repository at this point in the history

  4. need coffee, thank you travis

    @devendor
    devendor committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    88be776 View commit details
    Browse the repository at this point in the history

  5. Another approach to typecasting fix for jython. For some reason += th… 

    …rows TypeError, but .extend triggers implicit typecasting.
    @devendor
    devendor committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    9d4909a View commit details
    Browse the repository at this point in the history

  6. Add a comment so the non-obvious work around doesn't get housecleaned.

    @devendor
    devendor committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    1fabfcd View commit details
    Browse the repository at this point in the history

  7. Remove sloppy whitespace

    @devendor
    devendor committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    9422e07 View commit details
    Browse the repository at this point in the history
Loading