Codestyle + better retrieval of PHPVersion (through constant instead of function call)

frankmayer · frankmayer · commit 67273efdfaf6 · 2017-03-02T11:22:20.000+02:00
diff --git a/lib/ArangoDBClient/Autoloader.php b/lib/ArangoDBClient/Autoloader.php
@@ -87,7 +87,7 @@ public static function load($className)
      */
     private static function checkEnvironment()
     {
-        list($major, $minor) = explode('.', phpversion());
+        list($major, $minor) = explode('.', PHP_VERSION);
 
         if ((int) $major < 5 || ((int) $major === 5 && (int) $minor < 6)) {
             throw new ClientException('Incompatible PHP environment. Expecting PHP 5.6 or higher');
diff --git a/lib/ArangoDBClient/HttpHelper.php b/lib/ArangoDBClient/HttpHelper.php
@@ -257,7 +257,7 @@ public static function transfer($socket, $request, $method)
                     $contentLength    = (int) substr($result, $pos + 16, 10); // 16 = strlen("content-length: ")
                     $contentLengthPos = $pos + 17; // 17 = 16 + 1 one digit
 
-                    if ($method === "HEAD") {
+                    if ($method === 'HEAD') {
                         // for HTTP HEAD requests, the server will respond
                         // with the proper Content-Length value, but will
                         // NOT return the body.

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ public static function load($className)`
`87`	`87`	`*/`
`88`	`88`	`private static function checkEnvironment()`
`89`	`89`	`{`
`90`		`- list($major, $minor) = explode('.', phpversion());`
	`90`	`+ list($major, $minor) = explode('.', PHP_VERSION);`
`91`	`91`
`92`	`92`	`if ((int) $major < 5 \|\| ((int) $major === 5 && (int) $minor < 6)) {`
`93`	`93`	`throw new ClientException('Incompatible PHP environment. Expecting PHP 5.6 or higher');`