Correct missing method implementation

gjtorikian · gjtorikian · commit 61cbe4cc442a · 2024-04-09T08:11:22.000-04:00
diff --git a/lib/html_pipeline/text_filter/image_filter.rb b/lib/html_pipeline/text_filter/image_filter.rb
@@ -9,7 +9,7 @@ class TextFilter
     #   <img src="http://example.com/test.jpg" alt=""/>.
 
     class ImageFilter < TextFilter
-      def call(text)
+      def call(text, context: {}, result: {})
         text.gsub(%r{(https|http)?://.+\.(jpg|jpeg|bmp|gif|png)(\?\S+)?}i) do |match|
           %(<img src="#{match}" alt=""/>)
         end
diff --git a/lib/html_pipeline/text_filter/plain_text_input_filter.rb b/lib/html_pipeline/text_filter/plain_text_input_filter.rb
@@ -5,7 +5,7 @@ class TextFilter
     # Simple filter for plain text input. HTML escapes the text input and wraps it
     # in a div.
     class PlainTextInputFilter < TextFilter
-      def call(text)
+      def call(text, context: {}, result: {})
         "<div>#{CGI.escapeHTML(text)}</div>"
       end
     end
diff --git a/lib/html_pipeline/version.rb b/lib/html_pipeline/version.rb
@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class HTMLPipeline
-  VERSION = "3.1.0"
+  VERSION = "3.1.1"
 end
diff --git a/test/html_pipeline/text_filter/plain_text_input_filter_test.rb b/test/html_pipeline/text_filter/plain_text_input_filter_test.rb
@@ -27,5 +27,15 @@ def test_html_escapes_plain_text_input
         doc.to_s,
       )
     end
+
+    def test_works_within_complete_pipeline
+      pipeline = HTMLPipeline.new(text_filters: [HTMLPipeline::TextFilter::PlainTextInputFilter.new])
+      result = pipeline.call("See: <http://example.org>")
+
+      assert_equal(
+        "<div>See: &lt;http://example.org&gt;</div>",
+        result[:output],
+      )
+    end
   end
 end
diff --git a/test/text_filter_test.rb b/test/text_filter_test.rb
@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require "test_helper"
+require "html_pipeline/text_filter/image_filter"
+
+ImageFilter = HTMLPipeline::TextFilter::ImageFilter
+
+class HTMLPipeline
+  class ImageFilterTest < Minitest::Test
+    def setup
+      @filter = ImageFilter
+    end
+
+    def test_jpg
+      assert_equal(
+        %(<img src="http://example.com/test.jpg" alt=""/>),
+        @filter.call(%(http://example.com/test.jpg)),
+      )
+    end
+
+    def test_jpeg
+      assert_equal(
+        %(<img src="http://example.com/test.jpeg" alt=""/>),
+        @filter.call(%(http://example.com/test.jpeg)),
+      )
+    end
+
+    def test_bmp
+      assert_equal(
+        %(<img src="http://example.com/test.bmp" alt=""/>),
+        @filter.call(%(http://example.com/test.bmp)),
+      )
+    end
+
+    def test_gif
+      assert_equal(
+        %(<img src="http://example.com/test.gif" alt=""/>),
+        @filter.call(%(http://example.com/test.gif)),
+      )
+    end
+
+    def test_png
+      assert_equal(
+        %(<img src="http://example.com/test.png" alt=""/>),
+        @filter.call(%(http://example.com/test.png)),
+      )
+    end
+
+    def test_https_url
+      assert_equal(
+        %(<img src="https://example.com/test.png" alt=""/>),
+        @filter.call(%(https://example.com/test.png)),
+      )
+    end
+  end
+end
