FIX: Show error message when social auth fails for suspended users (#34173)

pmusaraj · ZogStriP · pento · commit 2536f7e12b3c · 2025-08-11T11:28:06.000+10:00
Co-authored-by: Régis Hanol &lt;regis@hanol.fr&gt;
diff --git a/app/assets/javascripts/discourse/app/instance-initializers/auth-complete.js b/app/assets/javascripts/discourse/app/instance-initializers/auth-complete.js
@@ -53,7 +53,9 @@ export default {
                 ...properties,
               };
 
-              router.trigger("showLogin", props);
+              router.transitionTo("login").then(({ controller }) => {
+                controller.setProperties(props);
+              });
 
               next(() => callback?.());
             };
diff --git a/spec/system/social_authentication_spec.rb b/spec/system/social_authentication_spec.rb
@@ -437,6 +437,26 @@
         signup_page.open.click_social_button("facebook")
         expect(page).to have_css(".header-dropdown-toggle.current-user")
       end
+
+      context "with a suspended user" do
+        before do
+          user.suspended_till = 2.years.from_now
+          user.suspended_at = Time.now
+          user.save!
+        end
+
+        it "shows suspended message" do
+          mock_facebook_auth
+          visit("/")
+
+          signup_page.open.click_social_button("facebook")
+
+          expect(page).to have_css(
+            ".alert-error",
+            text: I18n.t("login.suspended", date: I18n.l(user.suspended_till, format: :date_only)),
+          )
+        end
+      end
     end
 
     context "with Google" do
