Skip to content

Commit b3caa90

Browse files
authored
DEV: Check for mobile upload button presence (#24059)
If rendering would break before `_bindMobileUploadButton` - this would fail too, obscuring the original issue.
1 parent ebeb07f commit b3caa90

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

app/assets/javascripts/discourse/app/mixins/composer-upload-uppy.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -634,21 +634,23 @@ export default Mixin.create(ExtendableUploader, UppyS3Multipart, {
634634
this.mobileUploadButton = document.getElementById(
635635
this.mobileFileUploaderId
636636
);
637-
this.mobileUploadButtonEventListener = () => {
638-
document.getElementById(this.fileUploadElementId).click();
639-
};
640-
this.mobileUploadButton.addEventListener(
637+
this.mobileUploadButton?.addEventListener(
641638
"click",
642-
this.mobileUploadButtonEventListener,
639+
this._mobileUploadButtonEventListener,
643640
false
644641
);
645642
}
646643
},
647644

645+
@bind
646+
_mobileUploadButtonEventListener() {
647+
document.getElementById(this.fileUploadElementId).click();
648+
},
649+
648650
_unbindMobileUploadButton() {
649651
this.mobileUploadButton?.removeEventListener(
650652
"click",
651-
this.mobileUploadButtonEventListener
653+
this._mobileUploadButtonEventListener
652654
);
653655
},
654656

0 commit comments

Comments
 (0)