Skip to content

FEATURE: rich editor link ui for editing it #32583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 11, 2025
Merged

FEATURE: rich editor link ui for editing it #32583

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7a4687d
FEATURE: rich editor link ui for editing it
renato Apr 26, 2025
3a6af69
DEV: tests + tweaks
renato May 12, 2025
3c71c5c
DEV: remove redundant boolean
renato May 12, 2025
ce68987
Merge branch 'main' into rich_editor_link_ui
renato May 16, 2025
37b1c9e
Merge branch 'main' into rich_editor_link_ui
renato May 19, 2025
92a4b43
Merge branch 'main' into rich_editor_link_ui
renato May 23, 2025
a097b87
Merge branch 'refs/heads/main' into rich_editor_link_ui
renato May 23, 2025
8eba0e2
Merge branch 'main' into rich_editor_link_ui
renato Jun 2, 2025
1fdd38e
DEV: refactor toolbar, using ToolbarBase; improves focus handling, ed…
renato Jun 4, 2025
537e3ef
Merge branch 'main' into rich_editor_link_ui
renato Jun 4, 2025
90c4ff6
DEV: lint
renato Jun 4, 2025
615284f
DEV: fix test
renato Jun 4, 2025
f7a37de
DEV: fix tests
renato Jun 4, 2025
3bfa94b
DEV: fix tests
renato Jun 4, 2025
abb7ff8
DEV: fix tests? + remove left transition
renato Jun 4, 2025
9d28c8a
DEV: fix tests?
renato Jun 5, 2025
84400ad
Merge branch 'main' into rich_editor_link_ui
renato Jun 10, 2025
e02cd2e
DEV: Address PR comments
renato Jun 10, 2025
bbfbf1e
DEV: all #private, simplification, etc
renato Jun 10, 2025
6bcb861
DEV: linting
renato Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DEV: Address PR comments
  • Loading branch information
@renato
renato committed Jun 10, 2025
commit e02cd2ebe397246b341f5ecdab649783a475dd08
10 changes: 7 additions & 3 deletions app/assets/javascripts/discourse/app/components/composer/toolbar-buttons.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ export default class ComposerToolbarButtons extends Component {
);
}

get rovingButtonBar() {
return this.args.rovingButtonBar || this.args.data.rovingButtonBar;
}

<template>
{{#each @data.groups key="group" as |group|}}
{{#each group.buttons key="id" as |button|}}
Expand All @@ -40,7 +44,7 @@ export default class ComposerToolbarButtons extends Component {
class={{concatClass "btn no-text btn-icon" button.className}}
title={{button.title}}
tabindex={{this.tabIndex button}}
{{on "keydown" (or @rovingButtonBar @data.rovingButtonBar)}}
{{on "keydown" this.rovingButtonBar}}
>
{{icon button.icon}}
</a>
Expand All @@ -50,7 +54,7 @@ export default class ComposerToolbarButtons extends Component {
@onChange={{button.popupMenu.action}}
@onOpen={{fn button.action button}}
@tabindex={{this.tabIndex button}}
@onKeydown={{or @rovingButtonBar @data.rovingButtonBar}}
@onKeydown={{this.rovingButtonBar}}
@options={{hash icon=button.icon focusAfterOnChange=false}}
class={{button.className}}
/>
Expand All @@ -63,7 +67,7 @@ export default class ComposerToolbarButtons extends Component {
@label={{button.label}}
@icon={{button.icon}}
@preventFocus={{button.preventFocus}}
@onKeyDown={{or @rovingButtonBar @data.rovingButtonBar}}
@onKeyDown={{this.rovingButtonBar}}
tabindex={{this.tabIndex button}}
class={{button.className}}
/>
Expand Down
Loading
Loading