Skip to content

DEV: Enable auth_skip_create_confirm on new sites #33073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

DEV: Enable auth_skip_create_confirm on new sites #33073

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4147178
Switch default and add migration
pmusaraj Jun 4, 2025
1760c9c
fix tests
pmusaraj Jun 4, 2025
a10b855
Fix system specs
pmusaraj Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Switch default and add migration
  • Loading branch information
@pmusaraj
pmusaraj committed Jun 4, 2025
commit 4147178b516ba7f697dc39a4f5bf0866d5838a89
2 changes: 1 addition & 1 deletion config/site_settings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ login:
regex: "^[a-zA-Z0-9_=\\.]+$"
secret: true
auth_skip_create_confirm:
default: false
default: true
client: true
auth_immediately:
default: true
Expand Down
15 changes: 15 additions & 0 deletions db/migrate/20250604181345_disable_auth_skip_create_confirm_existing_sites.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# frozen_string_literal: true

class DisableAuthSkipCreateConfirmExistingSites < ActiveRecord::Migration[7.2]
def up
execute <<~SQL if Migration::Helpers.existing_site?
INSERT INTO site_settings(name, data_type, value, created_at, updated_at)
VALUES('auth_skip_create_confirm', 5, 'f', NOW(), NOW())
ON CONFLICT (name) DO NOTHING
SQL
end

def down
raise ActiveRecord::IrreversibleMigration
end
end
Loading