Skip to content

FIX: hide header search for certain routes #34294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

FIX: hide header search for certain routes #34294

wants to merge 4 commits into from
+91 −22

Conversation

yuriyaran
Copy link
Contributor

@yuriyaran yuriyaran commented Aug 13, 2025 •
edited
Loading

Switches check from URL to a route name.

Fixes issue logged in https://meta.discourse.org/t/header-search-disappears-on-login-site-settings/377612.

@yuriyaran yuriyaran marked this pull request as ready for review August 14, 2025 08:32
dbattersby
dbattersby reviewed Aug 14, 2025
View reviewed changes
Copy link
Contributor

@dbattersby dbattersby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good overall, just some small feedback on the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CvX CvX CvX left review comments

@dbattersby dbattersby dbattersby approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuriyaran @CvX @dbattersby