refactor 415

fishercoder1534 · fishercoder1534 · commit 41e5bd53d667 · 2021-10-14T11:11:00.000-07:00
diff --git a/src/main/java/com/fishercoder/solutions/_415.java b/src/main/java/com/fishercoder/solutions/_415.java
@@ -3,35 +3,30 @@
 public class _415 {
 
     public static class Solution1 {
+        /**
+         * My completely original solution on 10/14/2021.
+         */
         public String addStrings(String num1, String num2) {
-            if (num1 == null || num1.length() == 0) {
-                return num2;
-            } else if (num2 == null || num2.length() == 0) {
-                return num1;
-            }
-
+            StringBuilder sb = new StringBuilder();
             int i = num1.length() - 1;
             int j = num2.length() - 1;
-            long carry = 0;
-            long sum = 0;
-            StringBuilder sb = new StringBuilder();
-            char[] char1 = num1.toCharArray();
-            char[] char2 = num2.toCharArray();
+            int carry = 0;
             while (i >= 0 || j >= 0) {
-                sum = carry;
+                int sum = carry;
                 if (i >= 0) {
-                    sum += Character.getNumericValue(char1[i--]);
+                    sum += Character.getNumericValue(num1.charAt(i));
                 }
                 if (j >= 0) {
-                    sum += Character.getNumericValue(char2[j--]);
+                    sum += Character.getNumericValue(num2.charAt(j));
                 }
-                carry = sum / 10;
                 sb.append(sum % 10);
+                carry = sum / 10;
+                i--;
+                j--;
             }
-            if (carry != 0) {
+            if (carry > 0) {
                 sb.append(carry);
             }
-
             return sb.reverse().toString();
         }
     }
diff --git a/src/test/java/com/fishercoder/_415Test.java b/src/test/java/com/fishercoder/_415Test.java
@@ -1,7 +1,6 @@
 package com.fishercoder;
 
 import com.fishercoder.solutions._415;
-import org.junit.Before;
 import org.junit.BeforeClass;
 import org.junit.Test;
 
@@ -23,45 +22,31 @@ public static void setup() {
         num2 = new String();
     }
 
-    @Before
-    public void setupForEachTest() {
-        expected = "";
-        actual = "";
-        num1 = "";
-        num2 = "";
-    }
-
     @Test
     public void test1() {
-
         num1 = "123";
         num2 = "34567";
         expected = "34690";
         actual = solution1.addStrings(num1, num2);
         assertEquals(expected, actual);
-
     }
 
     @Test
     public void test2() {
-
         num1 = "1";
         num2 = "9";
         expected = "10";
         actual = solution1.addStrings(num1, num2);
         assertEquals(expected, actual);
-
     }
 
     @Test
     public void test3() {
-
         num1 = "9";
         num2 = "99";
         expected = "108";
         actual = solution1.addStrings(num1, num2);
         assertEquals(expected, actual);
-
     }
 
 }
