refactor 154

fishercoder1534 · fishercoder1534 · commit 793a36eee63f · 2021-10-23T17:59:17.000-07:00
diff --git a/src/main/java/com/fishercoder/solutions/_154.java b/src/main/java/com/fishercoder/solutions/_154.java
@@ -2,27 +2,33 @@
 
 public class _154 {
     public static class Solution1 {
+        /**
+         * My completely original solution on 10/23/2021.
+         * Again, using a pen and paper to visualize all possible cases helps a great deal!
+         */
         public int findMin(int[] nums) {
             int left = 0;
             int right = nums.length - 1;
-            if (nums[left] < nums[right]) {
-                return nums[left];
-            }
-            int min = nums[0];
-            while (left + 1 < right) {
+            while (left < right) {
+                while (left + 1 < right && nums[left] == nums[left + 1]) {
+                    left++;
+                }
+                while (right - 1 > left && nums[right - 1] == nums[right]) {
+                    right--;
+                }
                 int mid = left + (right - left) / 2;
-                min = Math.min(min, nums[mid]);
-                if (nums[mid] > nums[left]) {
-                    min = Math.min(nums[left], min);
-                    left = mid + 1;
+                if (mid == left || mid == right) {
+                    break;
+                }
+                if (nums[mid] < nums[right]) {
+                    right = mid;
                 } else if (nums[mid] < nums[left]) {
-                    right = mid - 1;
-                } else {
-                    left++;
+                    left = mid;
+                } else if (nums[mid] > nums[right]) {
+                    left = mid + 1;
                 }
             }
-            min = Math.min(min, Math.min(nums[left], nums[right]));
-            return min;
+            return right >= 0 && nums[right] < nums[left] ? nums[right] : nums[left];
         }
     }
 }
diff --git a/src/test/java/com/fishercoder/_154Test.java b/src/test/java/com/fishercoder/_154Test.java
@@ -7,17 +7,29 @@
 import static org.junit.Assert.assertEquals;
 
 public class _154Test {
-  private static _154.Solution1 solution1;
-  private static int[] nums;
+    private static _154.Solution1 solution1;
+    private static int[] nums;
 
-  @BeforeClass
-  public static void setup() {
-    solution1 = new _154.Solution1();
-  }
+    @BeforeClass
+    public static void setup() {
+        solution1 = new _154.Solution1();
+    }
 
-  @Test
-  public void test1() {
-    nums = new int[] {1, 1, 1};
-    assertEquals(1, solution1.findMin(nums));
-  }
+    @Test
+    public void test1() {
+        nums = new int[]{1, 1, 1};
+        assertEquals(1, solution1.findMin(nums));
+    }
+
+    @Test
+    public void test2() {
+        nums = new int[]{4, 5, 6, 7, 0, 1, 4};
+        assertEquals(0, solution1.findMin(nums));
+    }
+
+    @Test
+    public void test3() {
+        nums = new int[]{1, 3, 5};
+        assertEquals(1, solution1.findMin(nums));
+    }
 }
