Skip to content

Commit b4f1e83

Browse files
committed
Remove test image after check
1 parent 61831a6 commit b4f1e83

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

src/mediaQueryHelper.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ var mediaQueryHelper = (function (cssMediaQuery) {
1313

1414
img.src = url;
1515

16-
document.querySelector('body').appendChild(img);
1716
return img;
1817
};
1918

@@ -34,7 +33,10 @@ var mediaQueryHelper = (function (cssMediaQuery) {
3433
var img = svgImgBlueByEmMediaQuery(),
3534
defer = ayepromise.defer();
3635

36+
document.querySelector('body').appendChild(img);
37+
3738
img.onload = function () {
39+
document.querySelector('body').removeChild(img);
3840
try {
3941
defer.resolve(!firstPixelHasColor(img, 0, 0, 255));
4042
} catch (e) {

test/specs/MediaQueryHelperSpec.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,14 @@ describe("Media Query Helper", function () {
3030
done();
3131
});
3232
});
33+
34+
it("should remove test image from DOM", function (done) {
35+
mediaQueryHelper.needsEmWorkaround().then(function () {
36+
expect($("img").length).toBe(0);
37+
38+
done();
39+
});
40+
});
3341
});
3442

3543
describe("workAroundWebKitEmSizeIssue", function () {

0 commit comments

Comments
 (0)